Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add archive param for proxmox_kvm module #6159

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Add archive param for proxmox_kvm module #6159

merged 1 commit into from
Mar 25, 2023

Conversation

l00ptr
Copy link
Contributor

@l00ptr l00ptr commented Mar 8, 2023

SUMMARY

We add a param to allow proxmox administrator to restore VM from an archives. This new option will be useful to automate automatic creation and restore of VM.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

proxmox_kvm

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @helldorado @joshainglis @karmab @tleguern
click here for bot help

@ansibullbot ansibullbot added cloud feature This issue/PR relates to a feature request module module labels Mar 8, 2023
@l00ptr l00ptr force-pushed the add-archive-param-proxmox branch from cd40b6c to 08af4bf Compare March 8, 2023 08:34
@ansibullbot ansibullbot added new_contributor Help guide this first time contributor plugins plugin (any type) labels Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@l00ptr l00ptr force-pushed the add-archive-param-proxmox branch from 08af4bf to 039aa57 Compare March 8, 2023 09:41
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Mar 8, 2023
felixfontein
felixfontein reviewed Mar 8, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments.

changelogs/fragments/6158-create-proxmox-vm-from-archive.yml Outdated Show resolved Hide resolved
plugins/modules/proxmox_kvm.py Show resolved Hide resolved
plugins/modules/proxmox_kvm.py Show resolved Hide resolved
plugins/modules/proxmox_kvm.py Outdated Show resolved Hide resolved
@l00ptr l00ptr force-pushed the add-archive-param-proxmox branch 2 times, most recently from 5262719 to 6e18a56 Compare March 9, 2023 16:38
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 9, 2023
@l00ptr l00ptr requested a review from felixfontein March 9, 2023 16:39
@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 9, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Mar 17, 2023
felixfontein
felixfontein reviewed Mar 19, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nobody objects, I'll merge this in a week (with my suggestion).

changelogs/fragments/6158-create-proxmox-vm-from-archive.yml Outdated Show resolved Hide resolved
Add archive param for proxmox_kvm module
4d2a77b 
We simply add a param to allow proxmox administrator to restore VM from
an archives. This new option will be useful to automate automatic
creation and restore of VM.
@l00ptr l00ptr force-pushed the add-archive-param-proxmox branch from 6e18a56 to 4d2a77b Compare March 22, 2023 10:01
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Mar 22, 2023
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 25, 2023
@felixfontein felixfontein merged commit 7059789 into ansible-collections:main Mar 25, 2023
@patchback
Copy link

patchback bot commented Mar 25, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/7059789f35edf25cc71d788fa87525489c009002/pr-6159

Backported as #6235

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 25, 2023
@l00ptr @patchback
Add archive param for proxmox_kvm module (#6159)
ea927e7 
We simply add a param to allow proxmox administrator to restore VM from
an archives. This new option will be useful to automate automatic
creation and restore of VM.

Co-authored-by: Julian Vanden Broeck <julian.vandenbroeck@dalibo.com>
(cherry picked from commit 7059789)
@patchback patchback bot mentioned this pull request Mar 25, 2023
Merged
@felixfontein
Copy link
Collaborator

@l00ptr thanks a lot for your contribution!

felixfontein pushed a commit that referenced this pull request Mar 25, 2023
@patchback @l00ptr
[PR #6159/7059789f backport][stable-6] Add archive param for proxmox_…
1d36db1 
…kvm module (#6235)

Add archive param for proxmox_kvm module (#6159)

We simply add a param to allow proxmox administrator to restore VM from
an archives. This new option will be useful to automate automatic
creation and restore of VM.

Co-authored-by: Julian Vanden Broeck <julian.vandenbroeck@dalibo.com>
(cherry picked from commit 7059789)

Co-authored-by: Julian <374571+l00ptr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
cloud feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l00ptr @ansibullbot @felixfontein