Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes dependency on StormSSH #6117

Merged
merged 10 commits into from
Mar 12, 2023
Merged

Removes dependency on StormSSH #6117

merged 10 commits into from
Mar 12, 2023

Conversation

peterupton
Copy link
Contributor

SUMMARY

Pull in StormSSH's config parser into ssh_config
Fixes #6009

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

ssh_config

ADDITIONAL INFORMATION

This PR simply pulls in the config parser from the now archived StormSSH into ssh_config itself.

@ansibullbot
Copy link
Collaborator

cc @Akasurde @gaqzi
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress module module new_contributor Help guide this first time contributor plugins plugin (any type) system labels Mar 1, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Mar 1, 2023
felixfontein
felixfontein reviewed Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments.

Please also adjust the tests (tests/integration/targets/ssh_config/tasks/main.yml) to not install stormssh, but only paramiko.

plugins/modules/ssh_config.py Show resolved Hide resolved
plugins/modules/ssh_config.py Outdated Show resolved Hide resolved
plugins/modules/ssh_config.py Outdated Show resolved Hide resolved
changelogs/fragments/6117-remove-stormssh-depend.yml Outdated Show resolved Hide resolved
changelogs/fragments/6117-remove-stormssh-depend.yml Outdated Show resolved Hide resolved
plugins/modules/ssh_config.py Show resolved Hide resolved
plugins/modules/ssh_config.py Outdated Show resolved Hide resolved
@ansibullbot ansibullbot added integration tests/integration module_utils module_utils tests tests and removed ci_verified Push fixes to PR branch to re-run CI labels Mar 2, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot

This comment was marked as outdated.

Sign in to view
felixfontein
felixfontein reviewed Mar 3, 2023
View reviewed changes
plugins/modules/ssh_config.py Outdated Show resolved Hide resolved
plugins/module_utils/_stormssh.py Outdated Show resolved Hide resolved
plugins/module_utils/_stormssh.py Outdated Show resolved Hide resolved
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Mar 3, 2023
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Mar 4, 2023
felixfontein
felixfontein reviewed Mar 4, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think besides these two small points it is ready for merging!

plugins/modules/ssh_config.py Outdated Show resolved Hide resolved
plugins/modules/ssh_config.py Outdated Show resolved Hide resolved
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Mar 4, 2023
@peterupton peterupton changed the title WIP: Removes dependency on StormSSH Removes dependency on StormSSH Mar 4, 2023
@ansibullbot ansibullbot removed the WIP Work in progress label Mar 4, 2023
@peterupton
Copy link
Contributor Author

@mjfinney, @felixfontein, and others, let me know if this looks good. Should be ready to merge.

felixfontein
felixfontein approved these changes Mar 4, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nobody objects, I'll merge this in a week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 12, 2023
@felixfontein felixfontein merged commit 3862de3 into ansible-collections:main Mar 12, 2023
@patchback
Copy link

patchback bot commented Mar 12, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/3862de3f153c4401b7d77dba9e71a6535973ecb4/pr-6117

Backported as #6179

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 12, 2023
@peterupton @patchback
Removes dependency on StormSSH (#6117)
3f09ddb 
* included storm config parser

* Add changelog fragment

* Fix changelog fragment

* address PR feedback

* fix license

* add required boilerplate, fix issues found in test output

* move __future__ imports

* address pr feedback

* address test output

* address pr feedback

(cherry picked from commit 3862de3)
@patchback patchback bot mentioned this pull request Mar 12, 2023
Merged
@felixfontein
Copy link
Collaborator

@peterupton thanks a lot for your contribution!

felixfontein pushed a commit that referenced this pull request Mar 12, 2023
@patchback @peterupton
[PR #6117/3862de3f backport][stable-6] Removes dependency on StormSSH (…
8e84b3e 
…#6179)

Removes dependency on StormSSH (#6117)

* included storm config parser

* Add changelog fragment

* Fix changelog fragment

* address PR feedback

* fix license

* add required boilerplate, fix issues found in test output

* move __future__ imports

* address pr feedback

* address test output

* address pr feedback

(cherry picked from commit 3862de3)

Co-authored-by: Peter Upton <peterupton99@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
integration tests/integration module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssh_config: Remove dependency on StormSSH
3 participants
@peterupton @ansibullbot @felixfontein