-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dig lookup: fix DNSKEY's algorithm handling #5914
Conversation
shipit |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5915 🤖 @patchback |
Fix DNSKEY's algorithm handling. (cherry picked from commit 3da24d5)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5916 🤖 @patchback |
@jpmens thanks for reviewing this so quickly! |
Fix DNSKEY's algorithm handling. (cherry picked from commit 3da24d5)
SUMMARY
With dnspython 2.0.0+,
algorithm
of DNSKEY rdata is an enum type and no longer an int. Explicitly converting it toint
makes sure that it is an integer.Try
ansible localhost -m debug -a 'msg={{ q("dig", "com", qtype="DNSKEY", flat=0) }}'
with and without this PR, then you getvs
(I also updated the RRSIG field name list, while being at it.)
ISSUE TYPE
COMPONENT NAME
dig lookup plugin