Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: proxmox_disk - read time out on import #5803

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Bugfix: proxmox_disk - read time out on import #5803

merged 2 commits into from
Jan 23, 2023

Conversation

castorsky
Copy link
Contributor

SUMMARY

Use asynchronous post() API call for create actions instead of synchronous get().
Fixes #5753 .

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_disk

ADDITIONAL INFORMATION

There is no user friendly method to control requests timeout parameter from Ansible Playbook, so synchronous get() API call returns "read timeout" after default amount of time (it is 5 seconds now and it was enough for my servers to copy 300MB between storages).
Now the proxmox_disk module uses asyncronous calls and waits for tasks to finish (or reach timeout which can be controlled by the user).
Documentation has also been updated.

@ansibullbot
Copy link
Collaborator

cc @Ajpantuso @Thulium-Drake @joshainglis @karmab @tleguern
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud module module plugins plugin (any type) labels Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 9, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jan 17, 2023
felixfontein
felixfontein reviewed Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks good to me, as far as I can judge it. I'm wondering a bit whether this is more a feature or more a bugfix. In any case, I think it's better not to backport it to stable-5. I hope that's fine.

If nobody objects, I'll merge this in ~a week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 23, 2023
@felixfontein felixfontein merged commit f38bfad into ansible-collections:main Jan 23, 2023
@patchback
Copy link

patchback bot commented Jan 23, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/f38bfaddf0d9cb63e028a4bc14d732bc35039492/pr-5803

Backported as #5881

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 23, 2023
@castorsky @patchback
Bugfix: proxmox_disk - read time out on import (#5803)
aaa8857 
* Use async calls and fix docs

* Add changelog fragment

(cherry picked from commit f38bfad)
@patchback patchback bot mentioned this pull request Jan 23, 2023
Merged
@felixfontein
Copy link
Collaborator

@castorsky thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Jan 23, 2023
@patchback @castorsky
[PR #5803/f38bfadd backport][stable-6] Bugfix: proxmox_disk - read ti…
54099d7 
…me out on import (#5881)

Bugfix: proxmox_disk - read time out on import (#5803)

* Use async calls and fix docs

* Add changelog fragment

(cherry picked from commit f38bfad)

Co-authored-by: castorsky <csky57@gmail.com>
@castorsky castorsky deleted the proxmox-disk-import-timeout branch January 23, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxmox disk - Read time out when importing a disk
3 participants
@castorsky @ansibullbot @felixfontein