feat: add tags to proxmox containers #5714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
1 task
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Dec 23, 2022
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5745 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
* feat: add tags to proxmox containers * fix: correct version added * fix: code style * feat: changelog fragment * fix: correct version_added Co-authored-by: Felix Fontein <felix@fontein.de> * feat: fail on unsupported params, rather than silently ignoring them * fix: actually check unsupported feature presence before failing Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 2d4ce9f)
|
@GuillaumeV-cemea thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 30, 2022
…ainers (#5745) feat: add tags to proxmox containers (#5714) * feat: add tags to proxmox containers * fix: correct version added * fix: code style * feat: changelog fragment * fix: correct version_added Co-authored-by: Felix Fontein <felix@fontein.de> * feat: fail on unsupported params, rather than silently ignoring them * fix: actually check unsupported feature presence before failing Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 2d4ce9f) Co-authored-by: GuillaumeV-cemea <101114641+GuillaumeV-cemea@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added tag support for proxmox containers in PVE 7, to achieve feature parity with VMs which support tags since PVE6. Fixes #5471
ISSUE TYPE
COMPONENT NAME
proxmox.py
ADDITIONAL INFORMATION
I've restricted the tags feature to PVE 7, because I'm not sure if the original bug preventing tags in containers - from proxmox forum - has been fixed, and if yes, in which proxmox 6 version it has been fixed.
I've used the code from
proxmox_kvm.py, so the tag separator is still a,. It's not an issue because on PVE 7.0-7.2,,is the correct separator, and on pve 7.3, it's automatically changed (by proxmox) to a;(and proxmox inventory plugin support both separator, see #5602)