Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssh_config): host_key_algorithms option #5605

Conversation

koralowiec
Copy link
Contributor

SUMMARY

host_key_algorithms option for ssh_config module

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ssh_config

ADDITIONAL INFORMATION

Example ad hoc execution:

ansible localhost --connection=local -a \
  "host=example.com ssh_config_file=/tmp/ssh_config remote_user=mariusz host_key_algorithms=+ssh-rsa" \
  -m community.general.ssh_config

Result (content of /tmp/ssh_config):

Host example.com
    user mariusz
    hostkeyalgorithms +ssh-rsa

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Nov 26, 2022
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests labels Nov 26, 2022
@github-actions
Copy link

github-actions bot commented Nov 26, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Here are some first comments.

plugins/modules/ssh_config.py Show resolved Hide resolved
@koralowiec
Copy link
Contributor Author

Hi @felixfontein , I included your suggestions in the latest commit

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, and since nobody objected I'm going to merge this.

@felixfontein felixfontein merged commit fb2833d into ansible-collections:main Dec 4, 2022
@patchback
Copy link

patchback bot commented Dec 4, 2022

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/fb2833d34d5e8b389ed017084d87ea6b079d4d9b/pr-5605

Backported as #5653

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 4, 2022
patchback bot pushed a commit that referenced this pull request Dec 4, 2022
* feat(ssh_config): host_key_algorithms option

* chore: add changelog fragment

* chore(ssh_config): add version info to option and update fragment

(cherry picked from commit fb2833d)
@felixfontein
Copy link
Collaborator

@koralowiec thanks for contributing this feature!

felixfontein pushed a commit that referenced this pull request Dec 4, 2022
…orithms option (#5653)

feat(ssh_config): host_key_algorithms option (#5605)

* feat(ssh_config): host_key_algorithms option

* chore: add changelog fragment

* chore(ssh_config): add version info to option and update fragment

(cherry picked from commit fb2833d)

Co-authored-by: Arek Kalandyk <36413794+koralowiec@users.noreply.github.com>
@koralowiec koralowiec deleted the feat/ssh_config_host_key_algorithms branch December 4, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants