onepassword_raw - Add missing parameter to doc string #5511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
reviewed
Nov 8, 2022
No worry, ansible/ansible#69291 never got finished, so it won't fail :) |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
9a0e3fd to
58ae13e
Compare
|
Thanks for all your help @felixfontein! |
felixfontein
reviewed
Nov 9, 2022
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5518 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
* onepassword_raw - Add missing parameter to doc string * Remove redundant mention of default value * Update changelogs/fragments/5506-onepassword_raw-missing-param.yml Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c604cc5)
|
@samdoran thanks for this one as well! |
felixfontein
pushed a commit
that referenced
this pull request
Nov 9, 2022
* onepassword_raw - Add missing parameter to doc string * Remove redundant mention of default value * Update changelogs/fragments/5506-onepassword_raw-missing-param.yml Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit c604cc5) Co-authored-by: Sam Doran <sdoran@redhat.com>
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 10, 2022
…tions#5511) * onepassword_raw - Add missing parameter to doc string * Remove redundant mention of default value * Update changelogs/fragments/5506-onepassword_raw-missing-param.yml Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #5506
ISSUE TYPE
COMPONENT NAME
plugins/lookup/onepassword_raw.pyADDITIONAL INFORMATION
This might fail sanity tests since the version_added is 6.0.0 which is already release. Though I'm curious how this passed sanity tests originally...