[Scaleway] Remove unused sensitive values filtering #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Signed-off-by: Lunik <lunik@tiwabbit.fr>
e1adfbb to
1bbe2d0
Compare
Maybe that works aound the bug in pylint. (Also it won't be a breaking change anymore.)
|
Sorry for removing that change, but it seems to trigger a pylint bug in very certain circumstances (which seem to be fulfilled in CI, but not when I test locally). I'll try to re-do that in a follow-up commit, or at least rename the function with a leading underscore so that it is marked private (and we can remove it later without it being a breaking change). |
felixfontein
added a commit
to felixfontein/community.general
that referenced
this pull request
Nov 7, 2022
felixfontein
added a commit
to felixfontein/community.general
that referenced
this pull request
Nov 7, 2022
felixfontein
added a commit
that referenced
this pull request
Nov 7, 2022
russoz
pushed a commit
to russoz-ansible/community.general
that referenced
this pull request
Nov 10, 2022
…ons#5497) * [Scaleway] Remove unused sensitive values filtering Signed-off-by: Lunik <lunik@tiwabbit.fr> * Try adding function back. Maybe that works aound the bug in pylint. (Also it won't be a breaking change anymore.) Signed-off-by: Lunik <lunik@tiwabbit.fr> Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
added a commit
to felixfontein/community.general
that referenced
this pull request
Jan 18, 2023
felixfontein
added a commit
that referenced
this pull request
Jan 18, 2023
…nction private that should be removed (#5860) scaleway module utils: make function private that should be removed (#5499) * Make function private that should be removed (ref: #5497). * Maybe it works as a comment? * Try something else. * Ok, let's just add a comment. * Last try: docstring instead of comment. (cherry picked from commit c4b1836) Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR remove the call to
filter_sensitive_attributesin Scaleway modules.Also remove the
filter_sensitive_attributesfrom module utils.ISSUE TYPE
COMPONENT NAME
scaleway_container_namespace_infoscaleway_container_registry_infoscaleway_function_infoADDITIONAL INFORMATION
Since the returned values are hashed, we don't need to filter them from before return the to the user.
Also, the not
_infomodules already returns the hashed value.Should I make a Changelog fragment for this PR ?