Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #5349/2a54644c backport][stable-5] portage: drop usage of gentoolkit, add knobs for --with-bdeps, --backtrack #5365

Merged
merged 1 commit into from
Oct 14, 2022
Merged

[PR #5349/2a54644c backport][stable-5] portage: drop usage of gentoolkit, add knobs for --with-bdeps, --backtrack #5365

merged 1 commit into from
Oct 14, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 14, 2022

This is a backport of PR #5349 as merged into main (2a54644).

SUMMARY

This solves the issue brought up in #3870. The Portage Ansible module depends on an external shell command, when it could simply use the Portage module on every system that uses Portage.

Additionally, this adds support for handling the --with-bdeps and --backtrack emerge command line options.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Portage

ADDITIONAL INFORMATION

Similar to the other PR, this fixes the following kind of issue when running on a system that doesn't have the requisite external shell command:

host | FAILED! => {
    "ansible_facts": {
        "discovered_interpreter_python": "/usr/bin/python3.9"
    },
    "changed": false,
    "msg": "Failed to find required executable \"equery\" in paths: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin"
}

@ajakk @patchback
portage: drop usage of gentoolkit, add knobs for --with-bdeps, --back…
ff916b5 
…track (#5349)

* portage: drop dependency on gentoolkit (provides equery)

Portage installs a Python module, which is available anywhere that
Portage itself is available. We can use that instead of calling a
shell command.

Signed-off-by: John Helmert III <ajak@gentoo.org>

* portage: add knob for emerge's --backtrack flag

Signed-off-by: John Helmert III <ajak@gentoo.org>

* portage: add knob for portage's --with-bdeps option

Also, this option does not accept "True" like other options. Instead,
it only uses 'y' and 'n', so parse booleans properly into these chars.

Signed-off-by: John Helmert III <ajak@gentoo.org>

* Add changelog entry for #5349

Signed-off-by: John Helmert III <ajak@gentoo.org>

Signed-off-by: John Helmert III <ajak@gentoo.org>
(cherry picked from commit 2a54644)
@patchback patchback bot mentioned this pull request Oct 14, 2022
Merged
@ansibullbot
Copy link
Collaborator

cc @Tatsh @wltjr
click here for bot help

@ansibullbot ansibullbot added backport feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor os packaging plugins plugin (any type) labels Oct 14, 2022
@felixfontein felixfontein merged commit 22e0a6d into stable-5 Oct 14, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/2a54644cfa904d994ddf4fcc19bee7d603bff7ec/pr-5349 branch October 14, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor os packaging plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @ajakk