Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmcli: add transport_mode configuration for Infiniband devices #5361

Merged
merged 9 commits into from
Oct 23, 2022
Merged

nmcli: add transport_mode configuration for Infiniband devices #5361

merged 9 commits into from
Oct 23, 2022

Conversation

ThomasGebert
Copy link
Contributor

@ThomasGebert ThomasGebert commented Oct 14, 2022 •
edited
Loading

SUMMARY

Adds transport_mode configuration for Infiniband based IPoIB devices, which is one of:

  • datagram (default)
  • connected

Fixes #5356

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nmcli.py

ADDITIONAL INFORMATION

For Infiniband IPoIB devices like ib0 there are two different transport modes that can be chosen.

  • datagram
  • connected
# nmcli -t con show ib0 | grep infiniband.transport-mode
infiniband.transport-mode:datagram
# grep -H . /sys/class/net/ib0/{mtu,mode}
/sys/class/net/ib0/mtu:2044
/sys/class/net/ib0/mode:datagram

# nmcli -t con show ib0 | grep infiniband.transport-mode
infiniband.transport-mode:connected
# grep -H . /sys/class/net/ib0/{mtu,mode}
/sys/class/net/ib0/mtu:65520
/sys/class/net/ib0/mode:connected

Adds transport_mode configuration for Infiniband devices
5c006da 
Adds transport_mode configuration for Infiniband based ipoib devices,
which is one of:
  - datagram (default)
  - connected
@ansibullbot
Copy link
Collaborator

cc @alcamie101
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) labels Oct 14, 2022
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Oct 14, 2022
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Oct 14, 2022
@github-actions
Copy link

github-actions bot commented Oct 14, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ThomasGebert ThomasGebert changed the title [WIP] Add transport_mode configuration for Infiniband devices Add transport_mode configuration for Infiniband devices Oct 14, 2022
@ansibullbot ansibullbot removed the WIP Work in progress label Oct 14, 2022
@ThomasGebert ThomasGebert changed the title Add transport_mode configuration for Infiniband devices [WIP] Add transport_mode configuration for Infiniband devices Oct 14, 2022
@ansibullbot ansibullbot added the WIP Work in progress label Oct 14, 2022
@ThomasGebert ThomasGebert changed the title [WIP] Add transport_mode configuration for Infiniband devices Add transport_mode configuration for Infiniband devices Oct 14, 2022
@ansibullbot ansibullbot removed the WIP Work in progress label Oct 14, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Oct 14, 2022
felixfontein
felixfontein reviewed Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I've added some first comments.

changelogs/fragments/5361-nmcli-add-infiniband-transport-mode.yaml Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/net_tools/nmcli.py Outdated Show resolved Hide resolved
ThomasGebert and others added 4 commits October 14, 2022 17:28
@ThomasGebert @felixfontein
Update changelogs/fragments/5361-nmcli-add-infiniband-transport-mode.…
24ec384 
…yaml

Co-authored-by: Felix Fontein <felix@fontein.de>
@ThomasGebert @felixfontein
Update plugins/modules/net_tools/nmcli.py
44c3e21 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ThomasGebert @felixfontein
Update plugins/modules/net_tools/nmcli.py
e1548a0 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ThomasGebert
Remove default for transport_mode
db951d5
@felixfontein
Copy link
Collaborator

It would be great if you could extend the tests in tests/unit/plugins/modules/net_tools/test_nmcli.py to cover this new option.

@russoz russoz changed the title Add transport_mode configuration for Infiniband devices nmcli: add transport_mode configuration for Infiniband devices Oct 16, 2022
russoz
russoz approved these changes Oct 16, 2022
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Nov 20, 2022
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nmcli: add infiniband.transport-mode parameter to be configured
4 participants
@ThomasGebert @ansibullbot @felixfontein @russoz