-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmcli: honor IP options for VPNs #5228
nmcli: honor IP options for VPNs #5228
Conversation
This can be used for split tunneling - I extended a test as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will keep this open for some more days so others can comment on this as well.
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5252 🤖 @patchback |
@yan12125 thanks for fixing this! |
* nmcli: honor IP options for VPNs This can be used for split tunneling - I extended a test as an example. * Add changelog (cherry picked from commit 946c48d)
Glad to help :) |
* nmcli: honor IP options for VPNs This can be used for split tunneling - I extended a test as an example. * Add changelog
* nmcli: honor IP options for VPNs This can be used for split tunneling - I extended a test as an example. * Add changelog
SUMMARY
This can be used for split tunneling - I extended a test as an example.
ISSUE TYPE
COMPONENT NAME
nmcli
ADDITIONAL INFORMATION
Here is a complete example.
gw4_ignore_auto
is used as VPNs often come with a default route for0.0.0.0/0
.This example is based on an existing example. I'm not sure if it's a good idea to include such a complex usage in examples.
community.general/plugins/modules/net_tools/nmcli.py
Lines 1344 to 1359 in 2a449eb