-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding nested try block for tss.py to import new Delinea library #5151
Merged
felixfontein
merged 5 commits into
ansible-collections:main
from
tomreeb:tss_dilenea_patch
Aug 23, 2022
Merged
adding nested try block for tss.py to import new Delinea library #5151
felixfontein
merged 5 commits into
ansible-collections:main
from
tomreeb:tss_dilenea_patch
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ansibullbot
added
bug
This issue/PR relates to a bug
lookup
lookup plugin
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
labels
Aug 23, 2022
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
Push fixes to PR branch to re-run CI
has_issue
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Could you please add a changelog fragment? Thanks.
felixfontein
added
check-before-release
PR will be looked at again shortly before release and merged if possible.
backport-4
labels
Aug 23, 2022
Co-authored-by: Felix Fontein <felix@fontein.de>
delineaKrehl
approved these changes
Aug 23, 2022
Added a changelog fragment. |
ansibullbot
removed
the
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
label
Aug 23, 2022
tylerezimmerman
approved these changes
Aug 23, 2022
tylerezimmerman
approved these changes
Aug 23, 2022
tylerezimmerman
approved these changes
Aug 23, 2022
@felixfontein all issues have been resolved. Can this be approved and merged? |
delineaKrehl
approved these changes
Aug 23, 2022
Co-authored-by: Felix Fontein <felix@fontein.de>
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
has_issue
lookup
lookup plugin
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Thycotic has changed names to Delinea, as such the developers of the
thycotic-tss-sdk
package have updated their library. The latest version, 1.2.0, renamed the module fromthycotic
todelinea
. This update breaks thetss.py
lookup plugin because it no longer can importthycotic.secrets.server
. I've added a nestedtry:
block to the code to attempt to importdelinea.secrets.server
ifthycotic.secrets.server
fails. This maintains backwards compatibility with older versions on the library.ISSUE TYPE
COMPONENT NAME
tss.py
ADDITIONAL INFORMATION
Without this fix, the plugin would generate the following error: