Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmadm: deprecating unused parameter debug #4580

Merged
merged 2 commits into from
Apr 27, 2022
Merged

vmadm: deprecating unused parameter debug #4580

merged 2 commits into from
Apr 27, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Apr 27, 2022

SUMMARY

Parameter debug seems to be not used anywhere. Deprecating.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

plugins/modules/cloud/smartos/vmadm.py

@russoz
Copy link
Collaborator Author

russoz commented Apr 27, 2022 •
edited
Loading

I thought of setting a longer grace period, but given this parameter is literally not used anywhere, I think we can safely go with 6.0.0. Please let me know if it needs to go to 7.0.0.

@ansibullbot
Copy link
Collaborator

cc @bcoca @fishman @jasperla @jpdasma @mator @scathatheworm @troy2914 @xen0l
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud module module plugins plugin (any type) tests tests labels Apr 27, 2022
felixfontein
felixfontein approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this would have been a documented parameter I would have suggested to bump the removal version to 7.0.0, but since it's not even documented... Let's remove it in 6.0.0.

@felixfontein felixfontein merged commit c35bca6 into ansible-collections:main Apr 27, 2022
@felixfontein
Copy link
Collaborator

@russoz thanks!

@russoz russoz deleted the vmadm-deprecate-param-debug branch April 27, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russoz @ansibullbot @felixfontein