[PR #4459/06675034 backport][stable-3] dnsmadeeasy: only get monitor if it is not null api response #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only get monitor if it is not null api response * Add changelog fragment * Update changelogs/fragments/4459-only-get-monitor-if-it-is-not-null-api-response.yaml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/net_tools/dnsmadeeasy.py Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: drevai <revai.dominik@gravityrd.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 0667503)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4459 as merged into main (0667503).
SUMMARY
dnsmadeeasy module, fails if "monitor" key is null in the api response, this change adds a check
ISSUE TYPE
COMPONENT NAME
net_tools/dnsmadeeasy
ADDITIONAL INFORMATION
it adds a check for "monitor" value in api response partially fixes #3620, delete should work, updates are not perfect