Bugfix: zypper issue with specified package versions #4421

tover99 · 2022-03-29T16:33:51Z

zypper.py was doing nothing on state=present, when ALL requestet/checked packages had a specific version stated. This was caused by get_installed_state() being called with an empty package list, which in this case returns information about all ALL installed packages. This lead to an exessive filter list prerun_state, essentially removing all packages that are installed in ANY version on the target system from the request list.

SUMMARY

I added an empty check to prevent get_installed_state() being called with an empty package list.

Fixes ##4371

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

zypper

ADDITIONAL INFORMATION

The following task ALWAYS reported [ok] if ANY version of a-very-important-package was already installed on the target system.

    - name: Install a specific package version via zypper
      zypper:
        name:
          - "a-very-important-package=2.1"
        state: present
        oldpackage : yes

As soon as at least ONE other package WITHOUT a version specification was requestet, everything worked as expected.

    - name: Install a specific package version via zypper
      zypper:
        name:
          - "a-very-important-package=2.1"
          - "another-package"
        state: present
        oldpackage : yes

after my fix, that workaroud is not necessary and both of the above work as expected

zypper.py was doing nothing on state=present, when ALL requestet/checked packages had a specific version stated. This was caused by get_installed_state() being called with an empty package list, which in this case returns information about all ALL installed packages. This lead to an exessive filter list prerun_state, essentially removing all packages that are installed in ANY version on the target system from the request list.

ansibullbot · 2022-03-29T16:37:45Z

cc @AnderEnder @alxgu @andytom @commel @dcermak @evrardjp @lrupp @sealor @toabctl
click here for bot help

felixfontein

Thanks for your contribution! Can you add a changelog fragment? Thanks.

added changelog fragment for #4421

tover99 · 2022-03-29T20:38:13Z

Thanks for your contribution! Can you add a changelog fragment? Thanks.

done ... on 2nd try 🙈 ...

felixfontein

Looks good to me! If nobody complains, I'll merge beginning of next week.

(I'm not using zypper, so would be great if someone else who actually uses / knows zypper can take a look :) )

evrardjp

I am okay with this, but I didn't test it.

patchback · 2022-04-05T03:44:02Z

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/bbe231e2612a081c8c8489ba4c0c5554f2e06bda/pr-4421

Backported as #4445

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* fixed issue with specified package versions zypper.py was doing nothing on state=present, when ALL requestet/checked packages had a specific version stated. This was caused by get_installed_state() being called with an empty package list, which in this case returns information about all ALL installed packages. This lead to an exessive filter list prerun_state, essentially removing all packages that are installed in ANY version on the target system from the request list. * Create 4421-zypper_package_version_handling_fix added changelog fragment for #4421 * Delete 4421-zypper_package_version_handling_fix * Create 4421-zypper_package_version_handling_fix.yml (cherry picked from commit bbe231e)

patchback · 2022-04-05T03:44:13Z

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/bbe231e2612a081c8c8489ba4c0c5554f2e06bda/pr-4421

Backported as #4446

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* fixed issue with specified package versions zypper.py was doing nothing on state=present, when ALL requestet/checked packages had a specific version stated. This was caused by get_installed_state() being called with an empty package list, which in this case returns information about all ALL installed packages. This lead to an exessive filter list prerun_state, essentially removing all packages that are installed in ANY version on the target system from the request list. * Create 4421-zypper_package_version_handling_fix added changelog fragment for #4421 * Delete 4421-zypper_package_version_handling_fix * Create 4421-zypper_package_version_handling_fix.yml (cherry picked from commit bbe231e)

felixfontein · 2022-04-05T03:44:26Z

@tover99 thanks for fixing this!
@evrardjp thanks for reviewing!

* fixed issue with specified package versions zypper.py was doing nothing on state=present, when ALL requestet/checked packages had a specific version stated. This was caused by get_installed_state() being called with an empty package list, which in this case returns information about all ALL installed packages. This lead to an exessive filter list prerun_state, essentially removing all packages that are installed in ANY version on the target system from the request list. * Create 4421-zypper_package_version_handling_fix added changelog fragment for #4421 * Delete 4421-zypper_package_version_handling_fix * Create 4421-zypper_package_version_handling_fix.yml (cherry picked from commit bbe231e) Co-authored-by: tover99 <101673769+tover99@users.noreply.github.com>

ansibullbot added bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor os packaging plugins plugin (any type) small_patch Hopefully easy to review labels Mar 29, 2022

tover99 changed the title ~~fixed issue with specified package versions~~ Bugfix: zypper issue with specified package versions Mar 29, 2022

felixfontein reviewed Mar 29, 2022

View reviewed changes

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-3 labels Mar 29, 2022

tover99 added 2 commits March 29, 2022 22:22

Create 4421-zypper_package_version_handling_fix

6d1e28f

added changelog fragment for #4421

Delete 4421-zypper_package_version_handling_fix

832a500

ansibullbot removed the small_patch Hopefully easy to review label Mar 29, 2022

Create 4421-zypper_package_version_handling_fix.yml

dca961a

felixfontein approved these changes Mar 30, 2022

View reviewed changes

evrardjp reviewed Mar 30, 2022

View reviewed changes

felixfontein merged commit bbe231e into ansible-collections:main Apr 5, 2022

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 5, 2022

patchback bot mentioned this pull request Apr 5, 2022

[PR #4421/bbe231e2 backport][stable-3] Bugfix: zypper issue with specified package versions #4445

Merged

patchback bot mentioned this pull request Apr 5, 2022

[PR #4421/bbe231e2 backport][stable-4] Bugfix: zypper issue with specified package versions #4446

Merged

felixfontein mentioned this pull request May 2, 2022

zypper fails to install with specified version #4371

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix: zypper issue with specified package versions #4421

Bugfix: zypper issue with specified package versions #4421

tover99 commented Mar 29, 2022

ansibullbot commented Mar 29, 2022

felixfontein left a comment

tover99 commented Mar 29, 2022

felixfontein left a comment

evrardjp left a comment

patchback bot commented Apr 5, 2022 •

edited

Loading

patchback bot commented Apr 5, 2022 •

edited

Loading

felixfontein commented Apr 5, 2022

Bugfix: zypper issue with specified package versions #4421

Bugfix: zypper issue with specified package versions #4421

Conversation

tover99 commented Mar 29, 2022

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Mar 29, 2022

felixfontein left a comment

Choose a reason for hiding this comment

tover99 commented Mar 29, 2022

felixfontein left a comment

Choose a reason for hiding this comment

evrardjp left a comment

Choose a reason for hiding this comment

patchback bot commented Apr 5, 2022 • edited Loading

Backport to stable-3: 💚 backport PR created

patchback bot commented Apr 5, 2022 • edited Loading

Backport to stable-4: 💚 backport PR created

felixfontein commented Apr 5, 2022

patchback bot commented Apr 5, 2022 •

edited

Loading

patchback bot commented Apr 5, 2022 •

edited

Loading