ipa_service: Add skip_host_check option
#4417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for your contribution! Can you add a changelog fragment? Thanks.
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
6697166 to
9f548d6
Compare
|
Looks good to me. |
felixfontein
approved these changes
Mar 29, 2022
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #4436 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
* ipa_service: Add `skip_host_check` option * Update plugins/modules/identity/ipa/ipa_service.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_service.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_service.py Co-authored-by: Felix Fontein <felix@fontein.de> * changelogs/fragments: Add 4417-ipa_service-add-skip_host_check.yml Co-authored-by: sodd <4178855+sodd@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 1b357ba)
|
@sodd thanks for contributing this! |
felixfontein
pushed a commit
that referenced
this pull request
Apr 1, 2022
* ipa_service: Add `skip_host_check` option * Update plugins/modules/identity/ipa/ipa_service.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_service.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_service.py Co-authored-by: Felix Fontein <felix@fontein.de> * changelogs/fragments: Add 4417-ipa_service-add-skip_host_check.yml Co-authored-by: sodd <4178855+sodd@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 1b357ba) Co-authored-by: sodd <sodd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The ipa_service module missing
skip_host_checkoption to force service to be created even when host object does not exist to manage it. This PR adds new boolenskip_host_checkoption, which will handle this screnario.Fixes #4416
ISSUE TYPE
COMPONENT NAME
ipa_service
ADDITIONAL INFORMATION
n/a