[Bug] Scaleway The volume is created systematically on par1 #3964

xilmen · 2021-12-30T08:40:09Z

SUMMARY

Change of organization to project, depreciated in the api.
Added missing region parameter.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

This module allows to create volumes on the scw datacenter

ansibullbot · 2021-12-30T08:45:57Z

cc @QuentinBrosse @abarbare @jerome-quere @kindermoumoute @remyleone @sieben
click here for bot help

felixfontein · 2021-12-30T08:56:03Z

plugins/modules/cloud/scaleway/scaleway_volume.py

@@ -51,10 +51,10 @@
    description:
     - Name used to identify the volume.
    required: true
-  organization:
+  project:


This is a breaking change and will not be accepted. See #3951 for a way to do this as in a non-breaking fashion. It might also be better to rename this option to project and keep an alias for organization, if these two values mean the same to the API. @remyleone what do you think?

I think you can indeed follow #3951 to add support for a project. I don't think it is necessary to remove organization. Also, I fail to see why you would need a region argument, instance API uses zone such as fr-par-1 and not region such as fr-par. par1 is deprecated and you should use fr-par-1 to talk about this zone that belongs to the fr-par region.

I have added the changes to support organization

changelogs/fragments/3964-scaleway_volume_add_region.yml

plugins/modules/cloud/scaleway/scaleway_volume.py

felixfontein · 2021-12-31T08:56:59Z

plugins/modules/cloud/scaleway/scaleway_volume.py

    size = module.params['size']
    volume_type = module.params['volume_type']
+    module.params['api_url'] = SCALEWAY_LOCATION[region]["api_endpoint"]


Is this a bugfix? Is it related to the other bugfixes? If not, it should be a separate PR.

I need this part to have the scw aliases. example par1 = fr-par-1

felixfontein · 2021-12-31T08:58:19Z

plugins/modules/cloud/scaleway/scaleway_volume.py

@@ -123,14 +130,20 @@ def core(module):

    volumeByName = None
    for volume in volumes_json['volumes']:
+        if volume['project'] == project and volume['name'] == name:
+            volumeByName = volume
+
        if volume['organization'] == organization and volume['name'] == name:


Does the API return both organization and project with the same value? Or only one of these two?

I check with ansible -vvv i have 2 return from API:
organization: null
project: <ID_project>

So I guess if we pass organization has the place of project. The value of project would be null

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/cloud/scaleway/scaleway_volume.py

Co-authored-by: Felix Fontein <felix@fontein.de>

plugins/modules/cloud/scaleway/scaleway_volume.py

Co-authored-by: Rémy Léone <remy.leone@gmail.com>

remyleone · 2022-01-03T15:16:38Z

shipit

plugins/modules/cloud/scaleway/scaleway_volume.py

felixfontein · 2022-01-04T04:37:21Z

In that case, looks good to me as well!

patchback · 2022-01-05T16:53:06Z

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/125516b95752153cba8ff2715ccedac6d927bc82/pr-3964

Backported as #3983

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* [Bug] The volume is created systematically on par1 * add change log * added backward compatibility with organization * add documentation * change typo doc * Update changelogs/fragments/3964-scaleway_volume_add_region.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/scaleway/scaleway_volume.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/scaleway/scaleway_volume.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/scaleway/scaleway_volume.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/scaleway/scaleway_volume.py Co-authored-by: Rémy Léone <remy.leone@gmail.com> * optimization Co-authored-by: Romain SCHARFF <rscharff@plussimple.com> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Rémy Léone <remy.leone@gmail.com> (cherry picked from commit 125516b)

felixfontein · 2022-01-05T16:53:20Z

@xilmen thanks for your contribution!
@remyleone thanks for reviewing!

…3983) * [Bug] The volume is created systematically on par1 * add change log * added backward compatibility with organization * add documentation * change typo doc * Update changelogs/fragments/3964-scaleway_volume_add_region.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/scaleway/scaleway_volume.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/scaleway/scaleway_volume.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/scaleway/scaleway_volume.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/cloud/scaleway/scaleway_volume.py Co-authored-by: Rémy Léone <remy.leone@gmail.com> * optimization Co-authored-by: Romain SCHARFF <rscharff@plussimple.com> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Rémy Léone <remy.leone@gmail.com> (cherry picked from commit 125516b) Co-authored-by: xilmen <romain.scha@gmail.com>

[Bug] The volume is created systematically on par1

84fb82d

This comment has been minimized.

Sign in to view

ansibullbot added bug This issue/PR relates to a bug cloud module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) labels Dec 30, 2021

add change log

143ed59

felixfontein reviewed Dec 30, 2021

View reviewed changes

added backward compatibility with organization

ea3a559

This comment has been minimized.

Sign in to view

ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Dec 30, 2021

add documentation

9d8ad16

ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Dec 30, 2021

This comment has been minimized.

Sign in to view

change typo doc

664b1e1

ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 30, 2021

felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. labels Dec 31, 2021

felixfontein reviewed Dec 31, 2021

View reviewed changes

xilmen and others added 2 commits December 31, 2021 10:28

Update changelogs/fragments/3964-scaleway_volume_add_region.yml

a81a90e

Co-authored-by: Felix Fontein <felix@fontein.de>

Update plugins/modules/cloud/scaleway/scaleway_volume.py

1477831

Co-authored-by: Felix Fontein <felix@fontein.de>

ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 31, 2021

Update plugins/modules/cloud/scaleway/scaleway_volume.py

78b0566

Co-authored-by: Felix Fontein <felix@fontein.de>

ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Dec 31, 2021

This comment has been minimized.

Sign in to view

felixfontein reviewed Dec 31, 2021

View reviewed changes

plugins/modules/cloud/scaleway/scaleway_volume.py Outdated Show resolved Hide resolved

Update plugins/modules/cloud/scaleway/scaleway_volume.py

3751b8a

Co-authored-by: Felix Fontein <felix@fontein.de>

ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 31, 2021

xilmen requested a review from felixfontein January 3, 2022 14:43

remyleone reviewed Jan 3, 2022

View reviewed changes

plugins/modules/cloud/scaleway/scaleway_volume.py Outdated Show resolved Hide resolved

Update plugins/modules/cloud/scaleway/scaleway_volume.py

7a4d381

Co-authored-by: Rémy Léone <remy.leone@gmail.com>

felixfontein reviewed Jan 3, 2022

View reviewed changes

plugins/modules/cloud/scaleway/scaleway_volume.py Outdated Show resolved Hide resolved

optimization

8f5b181

felixfontein reviewed Jan 3, 2022

View reviewed changes

plugins/modules/cloud/scaleway/scaleway_volume.py Show resolved Hide resolved

felixfontein merged commit 125516b into ansible-collections:main Jan 5, 2022

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 5, 2022

patchback bot mentioned this pull request Jan 5, 2022

[PR #3964/125516b9 backport][stable-4] [Bug] Scaleway The volume is created systematically on par1 #3983

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] Scaleway The volume is created systematically on par1 #3964

[Bug] Scaleway The volume is created systematically on par1 #3964

xilmen commented Dec 30, 2021

This comment has been minimized.

ansibullbot commented Dec 30, 2021

felixfontein Dec 30, 2021

remyleone Dec 30, 2021

xilmen Dec 30, 2021

This comment has been minimized.

This comment has been minimized.

felixfontein Dec 31, 2021

xilmen Dec 31, 2021

felixfontein Dec 31, 2021

xilmen Dec 31, 2021

This comment has been minimized.

remyleone commented Jan 3, 2022

felixfontein commented Jan 4, 2022

patchback bot commented Jan 5, 2022 •

edited

Loading

felixfontein commented Jan 5, 2022

[Bug] Scaleway The volume is created systematically on par1 #3964

[Bug] Scaleway The volume is created systematically on par1 #3964

Conversation

xilmen commented Dec 30, 2021

SUMMARY

ISSUE TYPE

COMPONENT NAME

This comment has been minimized.

ansibullbot commented Dec 30, 2021

felixfontein Dec 30, 2021

Choose a reason for hiding this comment

remyleone Dec 30, 2021

Choose a reason for hiding this comment

xilmen Dec 30, 2021

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

felixfontein Dec 31, 2021

Choose a reason for hiding this comment

xilmen Dec 31, 2021

Choose a reason for hiding this comment

felixfontein Dec 31, 2021

Choose a reason for hiding this comment

xilmen Dec 31, 2021

Choose a reason for hiding this comment

This comment has been minimized.

remyleone commented Jan 3, 2022

felixfontein commented Jan 4, 2022

patchback bot commented Jan 5, 2022 • edited Loading

Backport to stable-4: 💚 backport PR created

felixfontein commented Jan 5, 2022

patchback bot commented Jan 5, 2022 •

edited

Loading