Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mattermost: Add sending of attachments #3946

Merged
merged 6 commits into from
Jan 3, 2022
Merged

Mattermost: Add sending of attachments #3946

merged 6 commits into from
Jan 3, 2022

Conversation

stndrf
Copy link
Contributor

@stndrf stndrf commented Dec 26, 2021

SUMMARY

Add the functionality to send attachments in Mattermost.

Closes: #3944

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mattermost

ADDITIONAL INFORMATION

I needed to remove the required=True at the text element and added additional documentation.

@ansibullbot
Copy link
Collaborator

cc @bjolivot
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor notification plugins plugin (any type) labels Dec 26, 2021
@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 26, 2021
@felixfontein felixfontein added backport-4 check-before-release PR will be looked at again shortly before release and merged if possible. labels Dec 26, 2021
felixfontein
felixfontein reviewed Dec 26, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? I added some first review comments below.

plugins/modules/notification/mattermost.py Show resolved Hide resolved
plugins/modules/notification/mattermost.py Show resolved Hide resolved
@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed ci_verified Push fixes to PR branch to re-run CI labels Dec 26, 2021
@ansibullbot ansibullbot removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Dec 26, 2021
@felixfontein
Change required arguments and add changelog
0533bf8 
- text was still default -> changed to required_one_of text or attachments
- Add version_added
- Add changelog fragment for mattermost attachments

Co-Authored-By: Felix Fontein <felix@fontein.de>
@ansibullbot

This comment has been minimized.

Sign in to view
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 27, 2021
stndrf and others added 3 commits December 27, 2021 09:24
@stndrf @felixfontein
Add trailing comma
249f2a9 
Co-authored-by: Felix Fontein <felix@fontein.de>
@stndrf @felixfontein
Remove default=None
f52057b 
Co-authored-by: Felix Fontein <felix@fontein.de>
@stndrf @felixfontein
Fix sentence
5396f39 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Dec 27, 2021
felixfontein
felixfontein approved these changes Dec 27, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If nobody complains in, say, a week, I'll merge this.

@felixfontein
Copy link
Collaborator

Closing and re-opening to re-trigger CI.

@felixfontein felixfontein reopened this Dec 27, 2021
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Dec 27, 2021
@felixfontein felixfontein reopened this Dec 27, 2021
@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 27, 2021
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 3, 2022
@felixfontein felixfontein merged commit 87ae203 into ansible-collections:main Jan 3, 2022
@patchback
Copy link

patchback bot commented Jan 3, 2022 •
edited
Loading

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/87ae203a7ddaec8502ed3835e988baceb14b6c9b/pr-3946

Backported as #3972

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@xobtoor thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Jan 3, 2022
@stndrf @patchback
Mattermost: Add sending of attachments (#3946)
1a1fcc1 
* Add sending of attachments

* Change required arguments and add changelog

- text was still default -> changed to required_one_of text or attachments
- Add version_added
- Add changelog fragment for mattermost attachments

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix wrong indentation

* Add trailing comma

Co-authored-by: Felix Fontein <felix@fontein.de>

* Remove default=None

Co-authored-by: Felix Fontein <felix@fontein.de>

* Fix sentence

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 87ae203)
@patchback patchback bot mentioned this pull request Jan 3, 2022
Merged
felixfontein pushed a commit that referenced this pull request Jan 3, 2022
@patchback @stndrf
Mattermost: Add sending of attachments (#3946) (#3972)
89560ea 
* Add sending of attachments

* Change required arguments and add changelog

- text was still default -> changed to required_one_of text or attachments
- Add version_added
- Add changelog fragment for mattermost attachments

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Fix wrong indentation

* Add trailing comma

Co-authored-by: Felix Fontein <felix@fontein.de>

* Remove default=None

Co-authored-by: Felix Fontein <felix@fontein.de>

* Fix sentence

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 87ae203)

Co-authored-by: xobtoor <313188+xobtoor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor notification plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mattermost: Add attachments message
3 participants
@stndrf @ansibullbot @felixfontein