-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logstash_plugin - invoke run_command passing list #3808
Merged
felixfontein
merged 3 commits into
ansible-collections:main
from
russoz:logstash_plugin-run_command-list
Dec 1, 2021
Merged
logstash_plugin - invoke run_command passing list #3808
felixfontein
merged 3 commits into
ansible-collections:main
from
russoz:logstash_plugin-run_command-list
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This issue/PR relates to a feature request
module
module
monitoring
plugins
plugin (any type)
labels
Nov 29, 2021
felixfontein
added
backport-4
check-before-release
PR will be looked at again shortly before release and merged if possible.
labels
Nov 30, 2021
felixfontein
approved these changes
Nov 30, 2021
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #3827 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 1, 2021
* logstash_plugin - invoke run_command passing list * added changelog fragment * rogue chglog frag escaped its caged and was seen running around into a different PR (cherry picked from commit c587d21)
@RUSSO thanks! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 1, 2021
* logstash_plugin - invoke run_command passing list * added changelog fragment * rogue chglog frag escaped its caged and was seen running around into a different PR (cherry picked from commit c587d21) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
felixfontein
removed
the
check-before-release
PR will be looked at again shortly before release and merged if possible.
label
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
This issue/PR relates to a feature request
module
module
monitoring
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Passing command as list instead of as string.
ISSUE TYPE
COMPONENT NAME
plugins/modules/monitoring/logstash_plugin.py