change ip4 type to list of str #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Can you please add a changelog fragment? Thanks. |
|
ok, let me just add some tests and examples to documentation |
|
Adding multiple addresses support for ip6 needs more time to implement, so i'll make another pull request later. |
Ajpantuso
requested changes
Nov 18, 2021
changelogs/fragments/1088-nmcli_add_multiple_addresses_support.yml
Outdated
Show resolved
Hide resolved
….yml Co-authored-by: Andrew Pantuso <ajpantuso@gmail.com>
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #3757 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 19, 2021
* change ip4 type to list of str * Add several tests and change documentation * Update changelogs/fragments/1088-nmcli_add_multiple_addresses_support.yml Co-authored-by: Andrew Pantuso <ajpantuso@gmail.com> Co-authored-by: Andrew Pantuso <ajpantuso@gmail.com> (cherry picked from commit 50c2f3a)
|
@haddystuff thanks for implementing this! |
felixfontein
pushed a commit
that referenced
this pull request
Nov 19, 2021
* change ip4 type to list of str * Add several tests and change documentation * Update changelogs/fragments/1088-nmcli_add_multiple_addresses_support.yml Co-authored-by: Andrew Pantuso <ajpantuso@gmail.com> Co-authored-by: Andrew Pantuso <ajpantuso@gmail.com> (cherry picked from commit 50c2f3a) Co-authored-by: Alex Groshev <38885591+haddystuff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds support of multiple ipv4 addresses on one interface which was requested here #1088.
ISSUE TYPE
COMPONENT NAME
plugins/modules/net_tools/nmcli.py
ADDITIONAL INFORMATION
As it turns out changing type of parameter is enough to make it work.
Now list can be used in
ip4parameter in playbook, but string is also working, so it's backwards compatible.I didn't add any additional test or documentation just for now. I think such change need to be discussed first.