fix dummy interface bug #3618
Closed
fix dummy interface bug #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
connection_options work differently when detecting changes for 802-3-ethernet.mtu parameter. It causes problems with applying mtu setting.
Fixes #3612
ISSUE TYPE
COMPONENT NAME
plugins/modules/net_tools/nmcli.py
ADDITIONAL INFORMATION
I guess it's better not to devide two scenarious(detect_change true and false) in terms of 802-3-ethernet.mtu and apply auto mtu by default. This change causes setting 802-3-ethernet.mtu to "auto" when mtu parameter not specified for dummy,ethernet,team-slave types, but it looks like right decision in this case. Correct me if i'm wrong.