ipa_dnszone: add PTR synchronization support for dnszones #3374

ahambrick · 2021-09-14T19:13:15Z

SUMMARY

Fixes #1687

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

IPA

ADDITIONAL INFORMATION

Allows support for the idnsallowsyncptr in the IPA REST API:

{
    "id": 0, 
    "method": "dnszone_mod/1", 
    "params": [
        [
            "foo.bar"
        ], 
        {
            "idnsallowsyncptr": true, 
            "version": "2.237"
        }
    ]
}

ahambrick · 2021-09-14T19:17:17Z

First time contributor. Feedback greatly appreciated here. :)

felixfontein

Thanks for your contribution! Here are some first comments.

changelogs/fragments/3374-add-ipa-ptr-sync-support.yml

plugins/modules/identity/ipa/ipa_dnszone.py

ansibullbot · 2021-09-28T20:50:10Z

cc @Akasurde @Nosmoht @fxfitz @justchris1
click here for bot help

felixfontein · 2021-10-27T20:51:29Z

@ahambrick ping, are you still working on this?

needs_info

ahambrick · 2021-11-04T13:02:01Z

Hey @felixfontein Yeah - I'm still tracking this on the side. I'll review my commits and remind myself where things stand.

plugins/modules/identity/ipa/ipa_dnszone.py

ahambrick · 2021-12-22T16:15:04Z

@felixfontein
I wanted to ask about the "items" vs. "itens". In keeping w/ the rest of the code in this file, I opted for "itens" but can start steering towards "items".

felixfontein · 2021-12-22T16:25:37Z

@ahambrick to me it looks like itens is a typo and should always have been items. Also a search for 'itens' on the web didn't indicate this is a special term I'm not aware of. So I'd tend to use items instead in new code.

ahambrick · 2021-12-22T19:41:19Z

@felixfontein Thanks for the input - changes made/tested. Hoping this can maybe make 4.3.0?

felixfontein · 2021-12-23T12:22:26Z

@ahambrick 4.3.0 sounds good (I also suggested that in https://github.com/ansible-collections/community.general/pull/3374/files#r715330667). Could you please look at the remaining open suggestions?

changelogs/fragments/3374-add-ipa-ptr-sync-support.yml

plugins/modules/identity/ipa/ipa_dnszone.py

Co-authored-by: Felix Fontein <felix@fontein.de>

felixfontein · 2021-12-26T21:55:47Z

@justchris1 can you also take a look? I think it looks good, but I don't use IPA and this module :)

justchris1 · 2021-12-26T21:57:28Z

LGTM. shipit

patchback · 2021-12-27T08:35:28Z

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/84e45c2cc0ba4aa096aba0c58649d1fdfefad3ff/pr-3374

Backported as #3950

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* Add PTR synchronization support for dnszones * Add changelog fragment * Update changelogs/fragments/3374-add-ipa-ptr-sync-support.yml Update to reflect proper module name. Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_dnszone.py Add period. Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_dnszone.py Remove requires comment. Co-authored-by: Felix Fontein <felix@fontein.de> * Change type to boolean in following with API docs * Tested with needed changes made. * Fix documentation to max implementation * Check for specific params; allow for modifications if needed * Add PTR synchronization support for dnszones * Add changelog fragment * Update changelogs/fragments/3374-add-ipa-ptr-sync-support.yml Update to reflect proper module name. Co-authored-by: Felix Fontein <felix@fontein.de> * Remove trailing whitespace * Make use of full search and compare params * Fix formatting errors * Move the change flag outside of module check * Fix itens typo to items * Update dynamicupdate to a boolean * Remove unnecessary flags and options * Minor comment changes * Update changelogs/fragments/3374-add-ipa-ptr-sync-support.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_dnszone.py Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Anne-Marie Lee <alee@datainterfuse.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 84e45c2)

felixfontein · 2021-12-27T08:35:42Z

@ahambrick thanks for implementing this!
@justchris1 thanks for reviewing!

) * Add PTR synchronization support for dnszones * Add changelog fragment * Update changelogs/fragments/3374-add-ipa-ptr-sync-support.yml Update to reflect proper module name. Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_dnszone.py Add period. Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_dnszone.py Remove requires comment. Co-authored-by: Felix Fontein <felix@fontein.de> * Change type to boolean in following with API docs * Tested with needed changes made. * Fix documentation to max implementation * Check for specific params; allow for modifications if needed * Add PTR synchronization support for dnszones * Add changelog fragment * Update changelogs/fragments/3374-add-ipa-ptr-sync-support.yml Update to reflect proper module name. Co-authored-by: Felix Fontein <felix@fontein.de> * Remove trailing whitespace * Make use of full search and compare params * Fix formatting errors * Move the change flag outside of module check * Fix itens typo to items * Update dynamicupdate to a boolean * Remove unnecessary flags and options * Minor comment changes * Update changelogs/fragments/3374-add-ipa-ptr-sync-support.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/identity/ipa/ipa_dnszone.py Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Anne-Marie Lee <alee@datainterfuse.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 84e45c2) Co-authored-by: Annie Lee <hambriak@gmail.com>

ansibullbot added feature This issue/PR relates to a feature request identity module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Sep 14, 2021

felixfontein reviewed Sep 15, 2021

View reviewed changes

felixfontein added backport-3 check-before-release PR will be looked at again shortly before release and merged if possible. labels Sep 15, 2021

felixfontein changed the title ~~Add PTR synchronization support for dnszones~~ ipa_dnszone: add PTR synchronization support for dnszones Sep 20, 2021

This comment has been minimized.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed ci_verified Push fixes to PR branch to re-run CI labels Sep 20, 2021

This comment has been minimized.

Sign in to view

ansibullbot added ci_verified Push fixes to PR branch to re-run CI and removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Sep 20, 2021

felixfontein reviewed Sep 24, 2021

View reviewed changes

plugins/modules/identity/ipa/ipa_dnszone.py Show resolved Hide resolved

ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Sep 28, 2021

felixfontein removed the backport-3 label Oct 12, 2021

ansibullbot added the needs_info This issue requires further information. Please answer any outstanding questions label Oct 27, 2021

ansibullbot removed the needs_info This issue requires further information. Please answer any outstanding questions label Nov 4, 2021

felixfontein added the backport-4 label Nov 6, 2021

This comment has been minimized.

Sign in to view

ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! and removed stale_ci CI is older than 7 days, rerun before merging labels Dec 17, 2021

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 21, 2021

felixfontein reviewed Dec 22, 2021

View reviewed changes

plugins/modules/identity/ipa/ipa_dnszone.py Outdated Show resolved Hide resolved

plugins/modules/identity/ipa/ipa_dnszone.py Outdated Show resolved Hide resolved

felixfontein reviewed Dec 22, 2021

View reviewed changes

plugins/modules/identity/ipa/ipa_dnszone.py Outdated Show resolved Hide resolved

plugins/modules/identity/ipa/ipa_dnszone.py Outdated Show resolved Hide resolved

Move the change flag outside of module check

6784f12

Fix itens typo to items

30f7b46

Anne-Marie Lee added 3 commits December 23, 2021 08:14

Update dynamicupdate to a boolean

f99bf02

Remove unnecessary flags and options

f3d1a0e

Minor comment changes

e6cfc55

felixfontein reviewed Dec 24, 2021

View reviewed changes

changelogs/fragments/3374-add-ipa-ptr-sync-support.yml Show resolved Hide resolved

plugins/modules/identity/ipa/ipa_dnszone.py Outdated Show resolved Hide resolved

ahambrick and others added 2 commits December 26, 2021 14:59

Update changelogs/fragments/3374-add-ipa-ptr-sync-support.yml

992c724

Co-authored-by: Felix Fontein <felix@fontein.de>

Update plugins/modules/identity/ipa/ipa_dnszone.py

0915ef3

Co-authored-by: Felix Fontein <felix@fontein.de>

ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 26, 2021

felixfontein approved these changes Dec 26, 2021

View reviewed changes

felixfontein merged commit 84e45c2 into ansible-collections:main Dec 27, 2021

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 27, 2021

patchback bot mentioned this pull request Dec 27, 2021

[PR #3374/84e45c2c backport][stable-4] ipa_dnszone: add PTR synchronization support for dnszones #3950

Merged

ahambrick deleted the ipa_dnszone_ptr_sync_support branch January 7, 2022 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ipa_dnszone: add PTR synchronization support for dnszones #3374

ipa_dnszone: add PTR synchronization support for dnszones #3374

ahambrick commented Sep 14, 2021

ahambrick commented Sep 14, 2021

felixfontein left a comment

This comment has been minimized.

This comment has been minimized.

ansibullbot commented Sep 28, 2021

felixfontein commented Oct 27, 2021

ahambrick commented Nov 4, 2021

This comment has been minimized.

ahambrick commented Dec 22, 2021

felixfontein commented Dec 22, 2021

ahambrick commented Dec 22, 2021

felixfontein commented Dec 23, 2021

felixfontein commented Dec 26, 2021

justchris1 commented Dec 26, 2021

patchback bot commented Dec 27, 2021 •

edited

Loading

felixfontein commented Dec 27, 2021

ipa_dnszone: add PTR synchronization support for dnszones #3374

ipa_dnszone: add PTR synchronization support for dnszones #3374

Conversation

ahambrick commented Sep 14, 2021

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ahambrick commented Sep 14, 2021

felixfontein left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

ansibullbot commented Sep 28, 2021

felixfontein commented Oct 27, 2021

ahambrick commented Nov 4, 2021

This comment has been minimized.

ahambrick commented Dec 22, 2021

felixfontein commented Dec 22, 2021

ahambrick commented Dec 22, 2021

felixfontein commented Dec 23, 2021

felixfontein commented Dec 26, 2021

justchris1 commented Dec 26, 2021

patchback bot commented Dec 27, 2021 • edited Loading

Backport to stable-4: 💚 backport PR created

felixfontein commented Dec 27, 2021

patchback bot commented Dec 27, 2021 •

edited

Loading