Update lxd connection to use all documented vars for options (#3798) (#…

…3880)

* Update lxd connection to use documented vars

* Add a changelog fragment

* Add clarification to changelog description

* Shorten changelog fragment description

(cherry picked from commit 8f6866d)

Co-authored-by: Conner Crosby <conner@cavcrosby.tech>

changelogs/fragments/3798-fix-lxd-connection-option-vars-support.yml

@@ -0,0 +1,4 @@
+---
+minor_changes:
+  - lxd connection plugin - make sure that ``ansible_lxd_host``, ``ansible_executable``, and
+    ``ansible_lxd_executable`` work (https://github.com/ansible-collections/community.general/pull/3798).

plugins/connection/lxd.py

@@ -89,9 +89,9 @@ def exec_command(self, cmd, in_data=None, sudoable=True):
             local_cmd.extend(["--project", self.get_option("project")])
         local_cmd.extend([
             "exec",
-            "%s:%s" % (self.get_option("remote"), self._host),
+            "%s:%s" % (self.get_option("remote"), self.get_option("remote_addr")),
             "--",
-            self._play_context.executable, "-c", cmd
+            self.get_option("executable"), "-c", cmd
         ])
 
         local_cmd = [to_bytes(i, errors='surrogate_or_strict') for i in local_cmd]
@@ -126,7 +126,7 @@ def put_file(self, in_path, out_path):
         local_cmd.extend([
             "file", "push",
             in_path,
-            "%s:%s/%s" % (self.get_option("remote"), self._host, out_path)
+            "%s:%s/%s" % (self.get_option("remote"), self.get_option("remote_addr"), out_path)
         ])
 
         local_cmd = [to_bytes(i, errors='surrogate_or_strict') for i in local_cmd]
@@ -145,7 +145,7 @@ def fetch_file(self, in_path, out_path):
             local_cmd.extend(["--project", self.get_option("project")])
         local_cmd.extend([
             "file", "pull",
-            "%s:%s/%s" % (self.get_option("remote"), self._host, in_path),
+            "%s:%s/%s" % (self.get_option("remote"), self.get_option("remote_addr"), in_path),
             out_path
         ])