Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'idempotent' attribute #238

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Dec 29, 2024

SUMMARY

Adds a new attribute idempotent for module documentation, which states whether (resp. under which circumstances) the module is idempotent.

Related PRs:

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

module documentation

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.68%. Comparing base (953c1e2) to head (1d77571).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   96.67%   96.68%           
=======================================
  Files         112      112           
  Lines        7560     7561    +1     
  Branches     1074     1074           
=======================================
+ Hits         7309     7310    +1     
  Misses        173      173           
  Partials       78       78           
Flag Coverage Δ
integration 43.69% <ø> (-0.04%) ⬇️
sanity 31.59% <100.00%> (+0.02%) ⬆️
units 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 29, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.dns/branch/main

Comment on lines 21 to 24
idempotent:
description:
- When run twice in a row with the same arguments, the second invocation indicates no change.
- This assumes that the system controlled/queried by the module has not changed in a relevant way.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we has it in c.g.? :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be one of the next steps ;-) I've started the PRs here (c.crypto, c.dns, c.docker) since I know the content of the collections pretty well and was able to add the attribute everywhere. My next step would be to discuss this a bit further (especially the question about having another attribute for whether/when changed parameters are updated, or merging that attribute with this one), and then starting to add it to c.g (since that's going to be a lot of work since it requires good knowledge of every module it is added to).

Copy link
Contributor

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@felixfontein felixfontein merged commit 0c1d020 into ansible-collections:main Dec 30, 2024
41 checks passed
@felixfontein felixfontein deleted the docs branch December 30, 2024 20:11
@felixfontein
Copy link
Collaborator Author

@russoz thanks for reviewing this and the other PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants