openssl_csr: fix bad tests, avoid accepting invalid crl_distribution_points records #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com>
kristianheljas
approved these changes
Jan 2, 2023
Backport to stable-1: 💚 backport PR created✅ Backport PR branch: Backported as #561 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 2, 2023
…points records (#560) * Improve error handling. * Remove invalid tests. * Add changelog fragment. * Fix tests. * Improve exception catching. Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com> * Prevent empty full_name. * Fix condition. Make sure errors are caught. * Add more checks. Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com> (cherry picked from commit ddfb18b)
|
@kristianheljas thanks for reviewing this! |
felixfontein
added a commit
that referenced
this pull request
Jan 2, 2023
…points records (#560) (#561) * Improve error handling. * Remove invalid tests. * Add changelog fragment. * Fix tests. * Improve exception catching. Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com> * Prevent empty full_name. * Fix condition. Make sure errors are caught. * Add more checks. Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com> (cherry picked from commit ddfb18b) Co-authored-by: Felix Fontein <felix@fontein.de>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Nightly CI breaks due to the stricter checks in pyca/cryptography#7710.
ISSUE TYPE
COMPONENT NAME
openssl_csr
openssl_csr_pipe