Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-1] cryptography support: improve Python 2 Unicode handling #314

Merged
merged 4 commits into from
Oct 29, 2021
Merged

[stable-1] cryptography support: improve Python 2 Unicode handling #314

merged 4 commits into from
Oct 29, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Manual backport of #313 to stable-1.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/module_utils/crypto/cryptography_support.py

@felixfontein
Copy link
Contributor Author

@Ajpantuso would be glad if you can take a look at this one. I'm not 100% happy that there are no tests, but since it's the same code as in main (and that has tests) I think it's ok. (If this one would have tests it would need tests that run conditionally depending on which backend and library version is needed, which is different from main, since there are at least three cases and not just two.)

Ajpantuso
Ajpantuso requested changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment below, but otherwise looks good.

Ajpantuso
Ajpantuso approved these changes Oct 29, 2021
View reviewed changes
Copy link
Collaborator

@Ajpantuso Ajpantuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit b893252 into ansible-collections:stable-1 Oct 29, 2021
@felixfontein felixfontein deleted the backport/unicode branch October 29, 2021 19:11
@felixfontein
Copy link
Contributor Author

@Ajpantuso thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ajpantuso Ajpantuso Ajpantuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixfontein @Ajpantuso