Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2020-25646: no_log=True missing for private key content options #125

Merged
merged 4 commits into from
Oct 13, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fix CVE-2020-25646: several modules were missing no_log=True for privatekey_content (and similar) options.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openssl_csr
openssl_privatekey_info
openssl_publickey
openssl_signature
x509_certificate
x509_crl

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit 233d1af into ansible-collections:main Oct 13, 2020
@felixfontein felixfontein deleted the CVE-2020-25646 branch October 13, 2020 12:14
@felixfontein
Copy link
Contributor Author

@Andersson007 @resmo thanks a lot for reviewing!

@Andersson007
Copy link
Contributor

backport-1?

@felixfontein
Copy link
Contributor Author

@Andersson007 @resmo we're releasing 1.x.y releases from main. Once 2.0.0 is out, there will be a stable-1 branch which needs backports, but right now no backports are needed.

@Akasurde
Copy link
Member

Is this applicable for Ansible 2.9/8/7?

@felixfontein
Copy link
Contributor Author

@Akasurde no, the bugs appeared in ansible/ansible after stable-2.9 has been branched. The first official Ansible release affected is 2.10.0.

@Akasurde
Copy link
Member

Great thanks for the information.

@Andersson007
Copy link
Contributor

Andersson007 commented Oct 13, 2020

@Andersson007 @resmo we're releasing 1.x.y releases from main. Once 2.0.0 is out, there will be a stable-1 branch which needs backports, but right now no backports are needed.

@felixfontein ok, thanks for the info, please mark this in the release issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants