Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backoff logic to elb_application_lb_info #977

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Add backoff logic to elb_application_lb_info #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0dbdec
Add backoff logic to elb_info
marknet15 Mar 10, 2022
833863f
add changelog fragment
marknet15 Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/977-add-backoff-logic-elb-info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- Add backoff retry logic to elb_application_lb_info (https://github.com/ansible-collections/community.aws/pull/977)
17 changes: 11 additions & 6 deletions plugins/modules/elb_application_lb_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,13 @@

from ansible_collections.amazon.aws.plugins.module_utils.core import AnsibleAWSModule
from ansible_collections.amazon.aws.plugins.module_utils.core import is_boto3_error_code
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import boto3_tag_list_to_ansible_dict
from ansible_collections.amazon.aws.plugins.module_utils.ec2 import AWSRetry, boto3_tag_list_to_ansible_dict


@AWSRetry.jittered_backoff()
def get_paginator(connection, **kwargs):
paginator = connection.get_paginator('describe_load_balancers')
return paginator.paginate(**kwargs).build_full_result()


def get_alb_listeners(connection, module, alb_arn):
Expand Down Expand Up @@ -274,13 +280,12 @@ def list_load_balancers(connection, module):
names = module.params.get("names")

try:
load_balancer_paginator = connection.get_paginator('describe_load_balancers')
if not load_balancer_arns and not names:
load_balancers = load_balancer_paginator.paginate().build_full_result()
load_balancers = get_paginator(connection)
if load_balancer_arns:
load_balancers = load_balancer_paginator.paginate(LoadBalancerArns=load_balancer_arns).build_full_result()
load_balancers = get_paginator(connection, LoadBalancerArns=load_balancer_arns)
if names:
load_balancers = load_balancer_paginator.paginate(Names=names).build_full_result()
load_balancers = get_paginator(connection, Names=names)
except is_boto3_error_code('LoadBalancerNotFound'):
module.exit_json(load_balancers=[])
except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e: # pylint: disable=duplicate-except
Expand Down Expand Up @@ -324,7 +329,7 @@ def main():
)

try:
connection = module.client('elbv2')
connection = module.client('elbv2', retry_decorator=AWSRetry.jittered_backoff(retries=10))
except (botocore.exceptions.ClientError, botocore.exceptions.BotoCoreError) as e:
module.fail_json_aws(e, msg='Failed to connect to AWS')

Expand Down