Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kms_spec and kms_usage parameter for aws_kms module #774

Merged
merged 5 commits into from
Oct 21, 2021
Merged

kms_spec and kms_usage parameter for aws_kms module #774

merged 5 commits into from
Oct 21, 2021

Conversation

markuman
Copy link
Member

SUMMARY

Add missing parameters kms_spec and kms_usage for aws_kms module,

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_kms

@markuman markuman requested a review from tremble October 21, 2021 08:35
@ansibullbot
Copy link

cc @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Oct 21, 2021
alinabuzachis
alinabuzachis approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markuman Thanks! LGTM!

@tremble tremble added the gate label Oct 21, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit a7164ae into ansible-collections:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markuman @ansibullbot @tremble @alinabuzachis