Remove "missing credentials" tests #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws more thoroughly
…ghly in amazon.aws
|
recheck |
1 similar comment
|
recheck |
|
recheck |
|
recheck |
markuman
approved these changes
Aug 2, 2021
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Link PR in changelog SUMMARY Link PR in changelog Reviewed-by: Mark Chappell <None> Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
AWS Client creation is now done inside a helper module which is more thoroughly tested. Remove the extra tests from aws_api_gateway, ec2_asg, ec2_transit_gateway, lambda_policy, and rds_instance. They bring no significant value but do bump up the login failure count, which can result in the IPs getting temporarily black-listed
ISSUE TYPE
COMPONENT NAME
aws_api_gateway
ec2_asg
ec2_transit_gateway
lambda
lambda_policy
rds_instance
ADDITIONAL INFORMATION
https://github.com/ansible-collections/amazon.aws/blob/main/tests/integration/targets/module_utils_ec2/roles/connect_to_aws/tasks/main.yml