Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssm_parameter_store: add check mode support #653

Closed
wants to merge 1 commit into from
Closed

ssm_parameter_store: add check mode support #653

wants to merge 1 commit into from

Conversation

lmazardo
Copy link

@lmazardo lmazardo commented Jul 20, 2021 •
edited by alinabuzachis
Loading

SUMMARY

Implement check_mode on ssm_parameter_store

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ssm_parameter_store

@alinabuzachis
Copy link
Contributor

Hi @lmazardo, thank you for taking time to work on this feature. Could you please add some integration tests to test check_mode and a changelog fragment?

@ansibullbot
Copy link

cc @116davinder @jillr @markuman @mikedlr @nathanwebsterdotme @ozbillwang @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Jul 20, 2021
@tremble
Copy link
Contributor

tremble commented Jul 5, 2022

@lmazardo,

Thanks for taking the time to submit this PR. This PR appears to have stalled out, as such I've created a more comprehensive PR (#1309) which implements the check_mode and adds some tests too. To ensure idempotency was a little more complex than just skipping the calls.

@tremble tremble closed this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lmazardo @alinabuzachis @ansibullbot @tremble