Update documentation for security_groups parameter #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified documentation surrounding using security_groups for any VPC other than Default.
|
@wimnat this lgtm but there's been quite a few changes (including the shippable jobs definitions) since this PR was opened. Would you mind rebasing on the latest |
|
Reran tests, which automatically merge this against the main branch. I think we're good to merge this. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ns#61) Clarified documentation surrounding using security_groups for any VPC other than Default.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ns#61) Clarified documentation surrounding using security_groups for any VPC other than Default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified documentation surrounding using security_groups for any VPC other than Default.
SUMMARY
Updated documentation for security_groups param as it caught me out.
ISSUE TYPE
COMPONENT NAME
ec2_launch_template
ADDITIONAL INFORMATION
N/A