ssm connection plugin - allow s3 bucket to use it's own region setting #603
Conversation
|
Would also be nice for s3 bucket to have its own aws_profile that's different than the var:ansible_aws_ssm_profile for the connection so you don't have to create a new bucket if you have multiple AWS accounts. Similar to aws_secrets plugin. |
There was a problem hiding this comment.
@rrusso1982 Thank you for your contribution. Could you please add a changelog https://docs.ansible.com/ansible/latest/dev_guide/testing/sanity/changelog.html?
|
recheck |
There was a problem hiding this comment.
@rrusso1982 Can you expand the integration test tests/integration/targets/aws_ssm_parameter_store/tasks/main.yml and replace one of the region=ec2_region with bucket_region=ec2_region to see that CI is still passing?
So that CI is taking care about this parameter in further changes. Otherwise it looks good to me.
| @@ -4,6 +4,12 @@ community.aws Release Notes | |||
|
|
|||
| .. contents:: Topics | |||
|
|
|||
| v2.0.0 | |||
There was a problem hiding this comment.
I think the CHANGELOG.rst is somewhat autogenerated. You need to revert this and add a changelogs/fragments file
|
Hello ! What is blocking this PR ? <Code>AuthorizationQueryParametersError</Code>
<Message>Error parsing the X-Amz-Credential parameter; the region 'us-west-2' is wrong; expecting 'us-east-1'</Message>In the case where inside a dynamic inventpry you use : plugin: amazon.aws.aws_ec2
[...]
compose:
ansible_aws_ssm_region: placement.region |
|
@gillg the lack of integration tests and files are touched that must not be touched in feature/bug requests. |
|
duplicate, can be close |
|
Closed by duplicate #854 |
…ions#603) aws_s3 - fix issue when copy missing key from bucket SUMMARY ansible-collections#602 ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_s3 ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
SUMMARY
When using ssm to connect to systems in aws it is required that we utilize an s3 bucket to transfer files from the source to the destination server. When the bucket resides in a different region than the destination server the wrong s3 endpoint is being selected. This adds a new configuration value, ansible_aws_ssm_bucket_region, to allow the s3 buckets region to be set directly allowing the transfer to occur as would be expected.
ISSUE TYPE
COMPONENT NAME
plugins/connection/aws_ssm.py