Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs_taskdefinition: Documentation improvement #534

Merged
merged 11 commits into from
Apr 26, 2021
Merged

ecs_taskdefinition: Documentation improvement #534

merged 11 commits into from
Apr 26, 2021

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Apr 8, 2021 •
edited
Loading

SUMMARY

ecs_taskdefinition: Documentation improvement.

Fixes: #520 and #287

COMPONENT NAME

ecs_taskdefinition

@ansibullbot
Copy link

cc @Java1Guy @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) labels Apr 8, 2021
@goneri goneri added gate and removed gate labels Apr 10, 2021
@alinabuzachis
ecs_taskdefinition: Add depends_on feature
d9255cd 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis force-pushed the ec2_depends_on branch 2 times, most recently from 2903186 to aada41a Compare April 13, 2021 20:04
@ansibullbot ansibullbot added new_module New module new_plugin New plugin labels Apr 13, 2021
@alinabuzachis alinabuzachis force-pushed the ec2_depends_on branch 2 times, most recently from 4ed3384 to 3e45632 Compare April 13, 2021 20:18
@alinabuzachis
* Fix documentation and imports
9b427c7 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@ansibullbot ansibullbot removed new_module New module new_plugin New plugin labels Apr 13, 2021
@alinabuzachis
* Fix syntax errors
d01ecbf 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis
* Add integration tests
4d3b7c1 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis force-pushed the ec2_depends_on branch 2 times, most recently from cba5b3c to ee9e445 Compare April 20, 2021 12:58
@alinabuzachis alinabuzachis changed the title [WIP] ecs_taskdefinition: Add depends_on feature [WIP] ecs_taskdefinition: Documentation improvement Apr 20, 2021
@alinabuzachis alinabuzachis force-pushed the ec2_depends_on branch 2 times, most recently from b43fd8d to fd2b0ac Compare April 20, 2021 14:34
@alinabuzachis
* Update documentation
d615670 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis force-pushed the ec2_depends_on branch 2 times, most recently from 854b26c to 58d9f4d Compare April 21, 2021 15:44
@alinabuzachis alinabuzachis changed the title [WIP] ecs_taskdefinition: Documentation improvement ecs_taskdefinition: Documentation improvement Apr 21, 2021
@alinabuzachis alinabuzachis removed the WIP Work in progress label Apr 21, 2021
@alinabuzachis alinabuzachis mentioned this pull request Apr 21, 2021
Closed
@alinabuzachis alinabuzachis linked an issue Apr 21, 2021 that may be closed by this pull request
Feature request | support gpu with ecs task definition #287
Closed
@alinabuzachis
* Doc fix
be5c039 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis force-pushed the ec2_depends_on branch 2 times, most recently from f8a8b2f to 6eb3a6c Compare April 22, 2021 10:21
@alinabuzachis
* Doc fix
4310112 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
jillr
jillr reviewed Apr 22, 2021
View reviewed changes
plugins/modules/ecs_taskdefinition.py Outdated
Comment on lines 65 to 67
type: dict
suboptions:
description:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is missing the key for the suboption we talked about.

Suggested change
type: dict
suboptions:
description:
type: dict
suboptions:
credentialsParameter:
description:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jillr Thank you very much for this. Yeah, I think I lost it somewhere in the copy/paste process.

@alinabuzachis
* Documentation fix: add missing key
20d0691 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis
* Fix sanity
6adaa89 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
tremble
tremble requested changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alinabuzachis ,

Looks like there's a typo/thinko that's been copy and pasted in the validation. Otherwise looks ok and mostly just nits

@alinabuzachis
* Address reviewer's comments
73d490b 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
tremble
tremble requested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are my last nits...

plugins/modules/ecs_taskdefinition.py Outdated
if linux_param.get('maxSwap') and launch_type == 'FARGATE':
module.fail_json(msg='maxSwap parameter is not supported with the FARGATE launch type.')
elif linux_param.get('maxSwap') and linux_param['maxSwap'] < 0:
module.fail_json(msg='Accepted values are 0 or any positive integer.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
module.fail_json(msg='Accepted values are 0 or any positive integer.')
module.fail_json(msg='Accepted values for maxSwap are 0 or any positive integer.')

@alinabuzachis
* Doc fixing
9850095 
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@tremble
Copy link
Contributor

tremble commented Apr 26, 2021

Thanks for cleaning this up @alinabuzachis it's not the most interesting work for most people, but does make things much more user-friendly.

@tremble tremble added the gate label Apr 26, 2021
@ansible-zuul ansible-zuul bot merged commit 0b87626 into ansible-collections:main Apr 26, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 15, 2021
@ansible-zuul
[promoted]Merge pull request ansible-collections#534 from alinabuzach…
ca0c959 
…is/ec2_depends_on

ecs_taskdefinition: Documentation improvement

Reviewed-by: https://github.com/apps/ansible-zuul

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@0b87626
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@ansible-zuul
[promoted]Merge pull request ansible-collections#534 from alinabuzach…
3dfc17e 
…is/ec2_depends_on

ecs_taskdefinition: Documentation improvement

Reviewed-by: https://github.com/apps/ansible-zuul

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@0b87626
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 17, 2021
@ansible-zuul
[promoted]Merge pull request ansible-collections#534 from alinabuzach…
17783e0 
…is/ec2_depends_on

ecs_taskdefinition: Documentation improvement

Reviewed-by: https://github.com/apps/ansible-zuul

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@b6cde06
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#534 from alinabuzachis/ec2_dep…
e0284d0 
…ends_on

ecs_taskdefinition: Documentation improvement

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#534 from alinabuzachis/ec2_dep…
1a7f3af 
…ends_on

ecs_taskdefinition: Documentation improvement

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@ansible-zuul
Merge pull request ansible-collections#534 from alinabuzachis/ec2_dep…
b6cde06 
…ends_on

ecs_taskdefinition: Documentation improvement

Reviewed-by: https://github.com/apps/ansible-zuul
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@mandar242
ec2_eni: Add check_mode support to ec2_eni (ansible-collections#534)
6a0194b 
ec2_eni: Add check_mode support to ec2_eni

SUMMARY

Add check_mode support to ec2_eni.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_eni

Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr left review comments

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request has_issue module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable ECS ContainerDependency - DependsOn parameter Feature request | support gpu with ecs task definition
5 participants
@alinabuzachis @ansibullbot @tremble @jillr @goneri