Fix route53 idempotency issues #525
Merged
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
requested changes
Apr 5, 2021
|
The CAA order problem cannot be tested with the module - resp. only parts of it can be tested, and that test is already there (and the module satisfied that test). To fully test this, one needs to create CAA records in a different order than the module would create them. Since the module always sorts the CAA values, that's not possible with the module. |
tremble
approved these changes
Apr 6, 2021
|
@tremble thanks for reviewing and merging! |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Fix name comparison: AWS uses octal encoding for characters like '@' and '*'. * Fix CAA record ordering. * Add changelog fragment. * Add wildcard record test.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Fix name comparison: AWS uses octal encoding for characters like '@' and '*'. * Fix CAA record ordering. * Add changelog fragment. * Add wildcard record test.
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* Fix name comparison: AWS uses octal encoding for characters like '@' and '*'. * Fix CAA record ordering. * Add changelog fragment. * Add wildcard record test.
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ions#525) ec2_vpc_endpoint use module_utils helper for tagging SUMMARY ec2_vpc_endpoint use module_utils helper for tag management ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_vpc_endpoint Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Fix name comparison: AWS uses octal encoding for characters like '@' and '*'. * Fix CAA record ordering. * Add changelog fragment. * Add wildcard record test. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@351ba4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #524.
ISSUE TYPE
COMPONENT NAME
route53