Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_sync - add storage_class feature #497

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

alinabuzachis
Copy link
Contributor

SUMMARY

s3_sync - add support for chosing storage_class when objects are added to an S3 bucket.
Fixes: #358

ISSUE TYPE
  • Feature Pull Request

…ed to an S3 bucket.

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please :)

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Mar 24, 2021
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor niggle on the changelog, otherwise LGTM

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM feel free to merge once the tests pass (or I'll do so this evening)

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@tremble tremble merged commit 77c646b into ansible-collections:main Mar 24, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket.

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket.

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket.

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…-collections#497)

Wait for instance to start before attempting to attach a volume

SUMMARY
Following ansible-collections#481 ec2_vol tests failed because the instances hadn't finished starting before trying to attach
botocore.exceptions.ClientError: An error occurred (IncorrectState) when calling the AttachVolume operation: Instance 'i-0d740b81c23f11a4c' is not 'running'.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vol
ADDITIONAL INFORMATION
https://7860a9269d0955476c03-81788054a9528b940bcdbd064c8a3746.ssl.cf1.rackcdn.com/488/b02aebad5940f5500e4ccb93c093bc00339b2426/check/ansible-test-cloud-integration-aws-py36_1/110bed5/job-output.txt

Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[s3_sync] Add support for S3 storage class
3 participants