-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3_sync - add storage_class feature #497
s3_sync - add storage_class feature #497
Conversation
…ed to an S3 bucket. Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog please :)
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
cb9b864
to
b1dc65d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor niggle on the changelog, otherwise LGTM
be92207
to
f055165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM feel free to merge once the tests pass (or I'll do so this evening)
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
f055165
to
f0acf48
Compare
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket. Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket. Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
* s3_sync - add support for choosing storage_class when objects are added to an S3 bucket. Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
…-collections#497) Wait for instance to start before attempting to attach a volume SUMMARY Following ansible-collections#481 ec2_vol tests failed because the instances hadn't finished starting before trying to attach botocore.exceptions.ClientError: An error occurred (IncorrectState) when calling the AttachVolume operation: Instance 'i-0d740b81c23f11a4c' is not 'running'. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION https://7860a9269d0955476c03-81788054a9528b940bcdbd064c8a3746.ssl.cf1.rackcdn.com/488/b02aebad5940f5500e4ccb93c093bc00339b2426/check/ansible-test-cloud-integration-aws-py36_1/110bed5/job-output.txt Reviewed-by: None <None>
SUMMARY
s3_sync - add support for chosing storage_class when objects are added to an S3 bucket.
Fixes: #358
ISSUE TYPE