Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wafv2 modules #450
add wafv2 modules #450
Changes from 10 commits
9ccf6d0
c8d4665
7f02218
aa22c32
9dc70d0
58daed7
ce72329
0a759c2
2d5790f
f0c6c9e
2cdc723
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest to add a unit-test for this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm basically it is already covered by the integration test.
I've added different rules circumstances that must be covered by those functions and that must not be covered by those functions.
nested_byte_values_to_strings
andbyte_values_to_strings_before_compare
byte_match_statement
: https://github.com/ansible-collections/community.aws/pull/450/files#diff-766b578e1e76effb51404af767b665a1dbd0a00d378ac1645cbdbeb1916b006fR21or_statement
: https://github.com/ansible-collections/community.aws/pull/450/files#diff-766b578e1e76effb51404af767b665a1dbd0a00d378ac1645cbdbeb1916b006fR237wafv2_snake_dict_to_camel_dict()
ip_set_reference_statement
becomesIPSetReferenceStatement
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I know and this is the reason why I put
suggest
in bold. PLEASE, Don't force yourself to do it!I see two reasons to write unit-tests in your case:
Well, that's 3 reasons actually ^^.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth you should be able to copy most of the unit-test framework for these transforms from https://github.com/ansible-collections/amazon.aws/blob/main/tests/unit/module_utils/core/test_scrub_none_parameters.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, unit-test would be great for the others too :-).