Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_nat_gateway_info: add retry decorator to solve RequestLimitExceeded error #446

Merged
merged 1 commit into from
Feb 25, 2021
Merged

ec2_vpc_nat_gateway_info: add retry decorator to solve RequestLimitExceeded error #446

merged 1 commit into from
Feb 25, 2021

Conversation

alinabuzachis
Copy link
Contributor

SUMMARY

Solve RequestLimitExceeded error by adding the retry decorator

"msg": "An error occurred (RequestLimitExceeded) when calling the DescribeNatGateways operation (reached max retries: 4): Request limit exceeded."
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vpc_nat_gateway_info

@alinabuzachis alinabuzachis changed the title ec2_vpc_nat_gateway_info: add retry decorator to solve RequestLimitExceeded ec2_vpc_nat_gateway_info: add retry decorator to solve RequestLimitExceeded error Feb 25, 2021
@ansibullbot
Copy link

cc @Etherdaemon @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Feb 25, 2021
tremble
tremble requested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry. But otherwise LGTM

@alinabuzachis
ec2_vpc_nat_gateway_info: add retry decorator
c52fd96 
 * Solve RequestLimitExceeded error by adding the retry decorator

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis
Copy link
Contributor Author

@tremble I added the changelog. Thank you!

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Feb 25, 2021
@tremble tremble merged commit 52fb230 into ansible-collections:main Feb 25, 2021
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@alinabuzachis
[promoted]ec2_vpc_nat_gateway_info: add retry decorator (ansible-coll…
20896f4 
…ections#446)

* Solve RequestLimitExceeded error by adding the retry decorator

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Co-authored-by: Alina Buzachis <abuzachis@redhat.com>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@52fb230
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
ec2_vpc_nat_gateway_info: add retry decorator (ansible-collections#446)
19a1dca 
* Solve RequestLimitExceeded error by adding the retry decorator

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@alinabuzachis
ec2_vpc_nat_gateway_info: add retry decorator (ansible-collections#446)
0d5c40a 
* Solve RequestLimitExceeded error by adding the retry decorator

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@alinabuzachis @danielcotton
ec2_vpc_nat_gateway_info: add retry decorator (ansible-collections#446)
edbbe75 
* Solve RequestLimitExceeded error by adding the retry decorator

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
Add new "require_boto(3|core)_at_least() helpers (ansible-collections…
2574ca4 
…#446)

Add new "require_boto(3|core)_at_least() helpers

SUMMARY
We currently have lots of different ways we output that we needed a library, add a helper for our standard use-case of minimum botocore versions for a feature.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/core.py
plugins/modules/ec2_vol.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
alinabuzachis added a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@alinabuzachis @jillr
ec2_vpc_nat_gateway_info: add retry decorator (ansible-collections#446)
1e61cf6 
* Solve RequestLimitExceeded error by adding the retry decorator

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>

Co-authored-by: Alina Buzachis <abuzachis@redhat.com>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@52fb230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alinabuzachis @ansibullbot @tremble