Cleanup aws_config tests #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillr
approved these changes
Feb 24, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* More explanation as to why aws_config is 'unsupported' * Make sure aws_config tests create resources with the 'usual' names.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* More explanation as to why aws_config is 'unsupported' * Make sure aws_config tests create resources with the 'usual' names.
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* More explanation as to why aws_config is 'unsupported' * Make sure aws_config tests create resources with the 'usual' names.
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…s#429) Disable ec2_key, ec2_snapshot and ec2_group tests SUMMARY Work around ansible-collections#428 and ansible-collections#440 ansible-collections#441 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_key ec2_snapshot ec2_group ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: None <None> Reviewed-by: Paul Belanger <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…collections#878) ec2_group - Add egress_rules and purge_egress_rules aliases SUMMARY Fix ansible-collections#440 - exception running with --diff and --check when creating a new SG by adding a rule referencing a missing SG. Add egress_rules and purge_egress_rules aliases - while cleaning up the tests I kept writing "egress_rules" rather than "rules_egress". Cleanup and re-enable ec2_group tests Remove "Classic Networking" tests (we don't have this in CI and it'll be gone in August) Fix Group/VPC deletion in tests (cross-referenced rules weren't being deleted, wipe the rules first) ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_group ADDITIONAL INFORMATION fixes: ansible-collections#440 Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
mattclay/aws-terminator#133
ISSUE TYPE
COMPONENT NAME
aws_config
ADDITIONAL INFORMATION