Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong element spec for rules param in aws_s3_cors #408

Merged
merged 2 commits into from
Feb 11, 2021
Merged

fix wrong element spec for rules param in aws_s3_cors #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b40e48d
#404 fix wrong element spec for rules param
Feb 11, 2021
b73f0a8
#404 documentation fix
Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/404-fix-dict-element-for-rule-param-in-aws-s3-cors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- aws_s3_cors - fix element type for rules parameter. (https://github.com/ansible-collections/community.aws/pull/408).
4 changes: 2 additions & 2 deletions plugins/modules/aws_s3_cors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
description:
- Cors rules to put on the s3 bucket
type: list
elements: str
elements: dict
state:
description:
- Create or remove cors on the s3 bucket
Expand Down Expand Up @@ -147,7 +147,7 @@ def main():

argument_spec = dict(
name=dict(required=True, type='str'),
rules=dict(type='list', elements='str'),
rules=dict(type='list', elements='dict'),
state=dict(type='str', choices=['present', 'absent'], required=True)
)

Expand Down