ec2_vpc_nacl: add IPv6 support #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
requested changes
Feb 27, 2021
There was a problem hiding this comment.
Change looks sensible, and this includes integration tests. 1 small thing: please add a changelog fragment.
https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
|
@tremble thanks, I've added a changelog fragment. |
tremble
approved these changes
Mar 8, 2021
|
@boutetnico thanks for your submission. This change should be available with the next release (either 1.5.0 or 2.0.0) |
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@7bddc31
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Install ec2_eni test requirements SUMMARY ansible.netcommon needs the netaddr python package to be installed in the test env, add this to test-requirements. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_eni
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for IPv6 in
ec2_vpc_nacl.This follows an old PR: ansible/ansible#50004.
ISSUE TYPE
COMPONENT NAME
ec2_vpc_nacl.py
ADDITIONAL INFORMATION
I'm not a Python programmer and will be happy to receive feedback on this PR 😃.
In this PR, I have:
ec2_vpc_nacl.pyto detect if the provided CIDR is an IPv6 or not and provide the correct value to boto.ec2_vpc_naclmodule.It seems to me that the tests are failing for an unrelated reason to this PR as reported in #153.