Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awsretry/cloudfront distribution #297

Conversation

fnavarrodev
Copy link
Contributor

SUMMARY

Adding AWSRetry.exponential_backoff when updating a cloudfront distribution.

Fixes #296

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudfront_distribution

@tremble
Copy link
Contributor

tremble commented Nov 16, 2020

One additional thing, please add a changelog entry: https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs

@fnavarrodev fnavarrodev requested a review from tremble November 16, 2020 13:59
@ansibullbot
Copy link

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug has_issue integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Nov 16, 2020
@markuman
Copy link
Member

recheck

@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 21, 2022
@alinabuzachis
Copy link
Contributor

recheck

@markuman markuman added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch mergeit Merge the PR (SoftwareFactory) labels Feb 23, 2022
@markuman markuman added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Feb 23, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a9c5553 into ansible-collections:main Feb 23, 2022
@patchback
Copy link

patchback bot commented Feb 23, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/a9c55535bb787c73f93254440143c97df2d42416/pr-297

Backported as #949

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 23, 2022
Awsretry/cloudfront distribution

SUMMARY
Adding AWSRetry.exponential_backoff when updating a cloudfront distribution.
Fixes #296
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: matej <strahek@gmail.com>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Francesc Navarro <fnavarro@debelop.com>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <git@osuv.de>
(cherry picked from commit a9c5553)
@patchback
Copy link

patchback bot commented Feb 23, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/a9c55535bb787c73f93254440143c97df2d42416/pr-297

Backported as #950

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 23, 2022
Awsretry/cloudfront distribution

SUMMARY
Adding AWSRetry.exponential_backoff when updating a cloudfront distribution.
Fixes #296
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: matej <strahek@gmail.com>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Francesc Navarro <fnavarro@debelop.com>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <git@osuv.de>
(cherry picked from commit a9c5553)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 24, 2022
[PR #297/a9c55535 backport][stable-2] Awsretry/cloudfront distribution

This is a backport of PR #297 as merged into main (a9c5553).
SUMMARY
Adding AWSRetry.exponential_backoff when updating a cloudfront distribution.
Fixes #296
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 24, 2022
[PR #297/a9c55535 backport][stable-3] Awsretry/cloudfront distribution

This is a backport of PR #297 as merged into main (a9c5553).
SUMMARY
Adding AWSRetry.exponential_backoff when updating a cloudfront distribution.
Fixes #296
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…reaking change) (ansible-collections#297)

scrub_none_parameters - set default for descend_into_lists to True (breaking change)

Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.10 backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review has_issue integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudfront - Update Distribution - max retries exceeded
6 participants