-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix container param typing #249
Conversation
The container param was incorrectly set as a STR. Updated to correct type of DICT. Additionally added some additional text to docs to assist in finding potential container options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for taking the time to submit this PR.
A couple of things:
- please could you add a changelog fragment: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to
- Given the huge number of potential options for containers, I think it's reasonable to refer to the boto3 docs for the potential options. However, I'd rather we gave folks a bit of a helping hand in finding them.
It looks like the reason this one slipped through is that the tests are currently disabled
@@ -44,10 +44,10 @@ | |||
type: bool | |||
containers: | |||
description: | |||
- A list of containers definitions. | |||
- A list of containers definitions. You can find the full list of options in the boto3 docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A list of containers definitions. You can find the full list of options in the boto3 docs. | |
- A list of containers definitions. | |
- 'A full list of options can be found in the boto3 docs in the containerDefinitions argument to register_task_definition : | |
U(https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecs.html#ECS.Client.register_task_definition)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update docs in #238
) ec2_metadata_facts: fixing generated doc render SUMMARY Fixing the rendering of generated docs for ec2_metadata_facts as items within < > tags are being parsed out. Fixes ansible-collections#249 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_metadata_facts Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: None <None>
SUMMARY
The container param was incorrectly set as a STR. Updated to correct type of DICT.
Additionally added some additional text to docs to assist in finding potential container options
ISSUE TYPE
COMPONENT NAME
ecs_taskdefinition
ADDITIONAL INFORMATION
After applying fix, error resolved and taskdef was corrected successfully