Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #2219/cfdcc05 backport][stable-9] Cleanup tox configs and unit tests (#2219) #2228

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Feb 3, 2025

This is a manual backport of PR #2219 as merged into main (cfdcc05).

SUMMARY

As discussed in #2212 cleans up the unit tests to move importing some of the fixtures into conftest.py tox configs needed a little cleanup to ensure that things were consistently in the import path

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

pyproject.toml
tests/unit/conftest.py
tests/unit/plugins/
tox.ini

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin

SUMMARY
As discussed in ansible-collections#2212 cleans up the unit tests to move importing some of the fixtures into conftest.py
tox configs needed a little cleanup to ensure that things were consistently in the import path.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
pyproject.toml
tests/unit/conftest.py
tests/unit/plugins/
tox.ini
ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
@tremble tremble requested a review from GomathiselviS February 3, 2025 15:46
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Feb 3, 2025
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b20424291cc8450990f31754d3d22a02

ansible-galaxy-importer FAILURE in 5m 28s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 24s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4a98551 into ansible-collections:stable-9 Feb 3, 2025
81 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants