[PR #2221/eb964494 backport][stable-9] Various pylint fixups #2224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUMMARY simplifiable-if-statement (use return bool(...) rather than if (...); return True ; else ; return False consider-using-dict-items redefined-builtin (using id and input as variables) no-else-break redefined-outer-name (mostly fixtures) pointless-string-statement (Strings being used as comments, function documentation before function rather than as first line) Remove unused variable assignments ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/connection/aws_ssm.py plugins/module_utils/base.py plugins/module_utils/ec2.py plugins/module_utils/networkfirewall.py plugins/modules/application_autoscaling_policy.py plugins/modules/autoscaling_launch_config.py plugins/modules/autoscaling_lifecycle_hook.py plugins/modules/autoscaling_policy.py plugins/modules/batch_job_definition.py plugins/modules/cloudfront_distribution.py plugins/modules/cloudfront_response_headers_policy.py plugins/modules/codebuild_project.py plugins/modules/config_aggregation_authorization.py plugins/modules/config_delivery_channel.py plugins/modules/config_recorder.py plugins/modules/config_rule.py plugins/modules/data_pipeline.py plugins/modules/directconnect_gateway.py plugins/modules/directconnect_link_aggregation_group.py plugins/modules/dms_endpoint.py plugins/modules/dms_replication_subnet_group.py plugins/modules/dynamodb_table.py plugins/modules/dynamodb_ttl.py plugins/modules/ec2_carrier_gateway.py plugins/modules/ec2_win_password.py plugins/modules/ecs_ecr.py plugins/modules/ecs_service_info.py plugins/modules/ecs_taskdefinition.py plugins/modules/efs.py plugins/modules/efs_info.py plugins/modules/eks_cluster.py plugins/modules/elasticache.py plugins/modules/elasticache_parameter_group.py plugins/modules/elasticbeanstalk_app.py plugins/modules/elb_target.py plugins/modules/elb_target_group.py plugins/modules/iam_server_certificate.py plugins/modules/kinesis_stream.py plugins/modules/lightsail_snapshot.py plugins/modules/mq_broker.py plugins/modules/mq_user.py plugins/modules/mq_user_info.py plugins/modules/msk_cluster.py plugins/modules/networkfirewall_policy.py plugins/modules/opensearch_info.py plugins/modules/route53_wait.py plugins/modules/s3_cors.py plugins/modules/s3_lifecycle.py plugins/modules/s3_logging.py plugins/modules/s3_website.py plugins/modules/secretsmanager_secret.py plugins/modules/ses_identity.py plugins/modules/sqs_queue.py plugins/modules/storagegateway_info.py plugins/modules/waf_condition.py plugins/modules/waf_rule.py plugins/modules/wafv2_ip_set.py plugins/modules/wafv2_ip_set_info.py plugins/modules/wafv2_resources.py plugins/modules/wafv2_resources_info.py plugins/modules/wafv2_rule_group.py plugins/modules/wafv2_rule_group_info.py plugins/modules/wafv2_web_acl.py plugins/modules/wafv2_web_acl_info.py ADDITIONAL INFORMATION Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell (cherry picked from commit eb96449)
Merged
tremble
approved these changes
Jan 28, 2025
ab19c64
into
stable-9
9 of 83 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #2221 as merged into main (eb96449).
SUMMARY
simplifiable-if-statement(usereturn bool(...)rather thanif (...); return True ; else ; return Falseconsider-using-dict-itemsredefined-builtin(usingidandinputas variables)no-else-breakredefined-outer-name(mostly fixtures)pointless-string-statement(Strings being used as comments, function documentation before function rather than as first line)ISSUE TYPE
COMPONENT NAME
plugins/connection/aws_ssm.py
plugins/module_utils/base.py
plugins/module_utils/ec2.py
plugins/module_utils/networkfirewall.py
plugins/modules/application_autoscaling_policy.py
plugins/modules/autoscaling_launch_config.py
plugins/modules/autoscaling_lifecycle_hook.py
plugins/modules/autoscaling_policy.py
plugins/modules/batch_job_definition.py
plugins/modules/cloudfront_distribution.py
plugins/modules/cloudfront_response_headers_policy.py
plugins/modules/codebuild_project.py
plugins/modules/config_aggregation_authorization.py
plugins/modules/config_delivery_channel.py
plugins/modules/config_recorder.py
plugins/modules/config_rule.py
plugins/modules/data_pipeline.py
plugins/modules/directconnect_gateway.py
plugins/modules/directconnect_link_aggregation_group.py
plugins/modules/dms_endpoint.py
plugins/modules/dms_replication_subnet_group.py
plugins/modules/dynamodb_table.py
plugins/modules/dynamodb_ttl.py
plugins/modules/ec2_carrier_gateway.py
plugins/modules/ec2_win_password.py
plugins/modules/ecs_ecr.py
plugins/modules/ecs_service_info.py
plugins/modules/ecs_taskdefinition.py
plugins/modules/efs.py
plugins/modules/efs_info.py
plugins/modules/eks_cluster.py
plugins/modules/elasticache.py
plugins/modules/elasticache_parameter_group.py
plugins/modules/elasticbeanstalk_app.py
plugins/modules/elb_target.py
plugins/modules/elb_target_group.py
plugins/modules/iam_server_certificate.py
plugins/modules/kinesis_stream.py
plugins/modules/lightsail_snapshot.py
plugins/modules/mq_broker.py
plugins/modules/mq_user.py
plugins/modules/mq_user_info.py
plugins/modules/msk_cluster.py
plugins/modules/networkfirewall_policy.py
plugins/modules/opensearch_info.py
plugins/modules/route53_wait.py
plugins/modules/s3_cors.py
plugins/modules/s3_lifecycle.py
plugins/modules/s3_logging.py
plugins/modules/s3_website.py
plugins/modules/secretsmanager_secret.py
plugins/modules/ses_identity.py
plugins/modules/sqs_queue.py
plugins/modules/storagegateway_info.py
plugins/modules/waf_condition.py
plugins/modules/waf_rule.py
plugins/modules/wafv2_ip_set.py
plugins/modules/wafv2_ip_set_info.py
plugins/modules/wafv2_resources.py
plugins/modules/wafv2_resources_info.py
plugins/modules/wafv2_rule_group.py
plugins/modules/wafv2_rule_group_info.py
plugins/modules/wafv2_web_acl.py
plugins/modules/wafv2_web_acl_info.py
ADDITIONAL INFORMATION