Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare modules ec2_vpc_egress_igw for promotion #2152

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Prepare modules ec2_vpc_egress_igw for promotion #2152

merged 3 commits into from
Oct 2, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Sep 23, 2024 •
edited
Loading

SUMMARY
  • Refactor module ec2_vpc_egress_igw to use shared code from amazon.aws.plugins.module_utils.ec2
  • ec2_vpc_egress_igw - add support for tagging
ISSUE TYPE
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

ec2_vpc_egress_igw

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f2595810698443628fa3765a80312f82

❌ ansible-galaxy-importer FAILURE in 3m 59s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 42s
✔️ ansible-test-splitter SUCCESS in 4m 25s
❌ integration-community.aws-1 FAILURE in 5m 52s
Skipped 21 jobs

alinabuzachis
alinabuzachis reviewed Sep 25, 2024
View reviewed changes
alinabuzachis
alinabuzachis reviewed Sep 25, 2024
View reviewed changes
alinabuzachis
alinabuzachis reviewed Sep 25, 2024
View reviewed changes
plugins/modules/ec2_vpc_egress_igw_info.py Outdated

DOCUMENTATION = r"""
---
module: ec2_vpc_egress_igw_info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably suggest adding this new module directly into amazon.aws rather than here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alinabuzachis the new module has been removed and will be introduced with the migration of ec2_vpc_egress_igw to amazon.aws

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/eadb2dd3045348a4b40a2427fee005ca

✔️ ansible-galaxy-importer SUCCESS in 3m 22s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 42s
✔️ ansible-test-splitter SUCCESS in 4m 27s
❌ integration-community.aws-1 FAILURE in 7m 33s
Skipped 21 jobs

@abikouo abikouo force-pushed the ec2_vpc_egress_nacl_v1 branch from a2863b9 to 7430982 Compare September 25, 2024 16:22
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b7e9cfef7d13457593c0350f17f4bb2b

❌ ansible-galaxy-importer FAILURE in 5m 06s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 39s
✔️ ansible-test-splitter SUCCESS in 4m 22s
❌ integration-community.aws-1 FAILURE in 7m 05s
Skipped 21 jobs

@abikouo abikouo force-pushed the ec2_vpc_egress_nacl_v1 branch from 7430982 to 62cd919 Compare September 27, 2024 12:53
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/051404f0ee2f4d0f981731916bf7fae2

✔️ ansible-galaxy-importer SUCCESS in 3m 44s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 46s
✔️ ansible-test-splitter SUCCESS in 4m 16s
❌ integration-community.aws-1 FAILURE in 5m 41s
Skipped 21 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Oct 2, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/141b654ae379455fae05eea330e430d5

❌ ansible-galaxy-importer FAILURE in 4m 54s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 35s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-community.aws-1 SUCCESS in 5m 42s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7b51659 into ansible-collections:main Oct 2, 2024
52 of 67 checks passed
@alinabuzachis alinabuzachis mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@GomathiselviS GomathiselviS GomathiselviS approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abikouo @alinabuzachis @GomathiselviS