[PR #1801/4cad9ee5 backport][stable-5] Fix s3_sync and s3_logging integration tests #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix s3_sync and s3_logging integration tests SUMMARY See also: ansible-collections/amazon.aws#1511 At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced". https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/ This change to the defaults resulted in some of our tests failing. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_sync s3_logging ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 4cad9ee)
tremble
approved these changes
May 4, 2023
|
ansible-galaxy-importer is flaky - manually merging |
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
More fstring cleanup SUMMARY Now that we're using tox for more of our linting tests, add flynt (encourage the use of fstrings) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ec2_metadata_facts.py plugins/modules/s3_object.py pyproject.toml tox.ini ADDITIONAL INFORMATION flynt was mass-applied as part of the 6.0.0 but we didn't update the linters. Note: explicitly excludes ec2_metadata_facts because this is expected to be run on managed nodes as well as the controllers. This is also why ec2_metadata_facts doesn't include botocore or our usual module wrapper. Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1801 as merged into main (4cad9ee).
SUMMARY
See also: ansible-collections/amazon.aws#1511
At the end of April Amazon updated various S3 bucket defaults. Buckets now have public_access blocked by default, and object_owner set to "BucketOwnerEnforced".
https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/
This change to the defaults resulted in some of our tests failing.
ISSUE TYPE
COMPONENT NAME
s3_sync
s3_logging
ADDITIONAL INFORMATION