-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ansi escape sequences #1768
Conversation
recheck |
i'm not sure what is failing here. can someone help explain where i can find the logs for the integration-community.aws-10 test is located so i can figure out how to fix it? |
recheck |
Hi, I had an issue where Ansible via AWS Session Manager was failing for AWS Linux 2023. I manually updated my local code according to the suggestion here, but I discovered another issue as follow-up. It looked like that the ANSI Remove also removed the correct Python Interpreter Path, Ansible "discovered" a Python Path that did not exist.
Now Ansible runs fine via Session Manager Connection with AWS Linux 2023 as target. The escape should be checked again, maybe there is something escaped, that should not be escaped. |
recheck |
I have this problem too. |
recheck |
@Hokwang does this PR fix your issue? |
recheck |
FYI I have a PR out that addresses this problem in a different way: #1839 |
recheck |
I like your approach better. Your way fixes it at the root. I have tested in our environment and i believe you have the best approach. I'm going to close this PR so your method is used instead. |
… retries enabled (ansible-collections#1768) elb_application_lb_info - ensure queries for additional ALB data have retries enabled SUMMARY As per ansible-collections#1767 the queries to pull extra info about ALBs are hitting rate limits when there's a lot of ALBs. Unfortunately the initial list operation has limited server-side filtering capabilities (and we don't have consistent client side filtering implemented at this time). Ensure that all of the extra queries have retries with jittered backoff enabled. Additionally, drops a redundant describe_load_balancers call to retrieve the ip_address_type information. (added by ansible-collections#499) ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb_info ADDITIONAL INFORMATION I don't consider this a full fix for ansible-collections#1767 so I'm not using the "fixes". Reviewed-by: Alina Buzachis
Depends-On: #1793
SUMMARY
Fixes #1756. Amazon Linux 2003 and others have issue where the ansi color text is showing up in the output causing ansible to not be able to process the stdout correctly. this adds a regex to remove those ansi escape sequences.
ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION