ses: fix clearing notification topic

[kamilturek]

SUMMARY

Fixes #150. As per the docs, the SnsTopic parameter has to be omitted from the request in order to clear the notification setting.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ses_identity

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b98ff73bda554fccaa479c02b4813bd2

❌ ansible-galaxy-importer FAILURE in 4m 04s
✔️ build-ansible-collection SUCCESS in 12m 37s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 14m 36s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 55s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 13m 01s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 05s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 58s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 01s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 25s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 25s
✔️ ansible-test-changelog SUCCESS in 4m 20s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-community.aws-1 SUCCESS in 13m 16s
Skipped 21 jobs

[kamilturek]

I don't know what is causing the ansible-galaxy-importer failure.

[alinabuzachis]

recheck

[tremble]

Thanks for taking the time to submit this PR. I'm a little concerned about how this change behaves. As it is today this has the potential to wipe out configuration that people expect to still be there.

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d7210845d06e45c08ccda3ae0361684d

❌ ansible-galaxy-importer FAILURE in 3m 50s
✔️ build-ansible-collection SUCCESS in 13m 31s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 18m 36s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 36s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 05s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 13m 24s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 27s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 10s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 17s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 13s
✔️ ansible-test-changelog SUCCESS in 4m 32s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-community.aws-1 SUCCESS in 11m 08s
Skipped 21 jobs

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ff9fe42f17d143c0b13a5ee399ce4a55

✔️ ansible-galaxy-importer SUCCESS in 3m 47s
✔️ build-ansible-collection SUCCESS in 13m 02s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 58s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 47s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 57s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 56s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 49s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 44s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 26s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 38s
✔️ ansible-test-changelog SUCCESS in 4m 21s
✔️ ansible-test-splitter SUCCESS in 4m 52s
✔️ integration-community.aws-1 SUCCESS in 12m 29s
Skipped 21 jobs

[tremble]

Thanks for your work on this, I'm sorry it's taken a while to get back to you.

I've just pushed two minor tweaks, the first is just a minor formatting thing, we're starting to use darker/black to make our formatting more consistent. The second changed the "parameter not passed" logic slightly. Top level parameters will always be in "params", if they were omitted in the task then they show up as None.

[softwarefactory-project-zuul]

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

https://ansible.softwarefactory-project.io/zuul/buildset/1d2b6e81c7314263af4ee173a41a8a6a

❌ ansible-galaxy-importer FAILURE in 3m 50s
✔️ build-ansible-collection SUCCESS in 12m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 44s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 56s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 51s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 51s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 00s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 31s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 22s
✔️ ansible-test-changelog SUCCESS in 4m 49s
✔️ ansible-test-splitter SUCCESS in 4m 46s
✔️ integration-community.aws-1 SUCCESS in 11m 52s
Skipped 21 jobs

[tremble]

regate

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b378f71eea294d229945ad96cb1e6dda

✔️ ansible-galaxy-importer SUCCESS in 4m 43s
✔️ build-ansible-collection SUCCESS in 13m 53s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 03s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 54s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 54s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 12m 18s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 54s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 13s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 32s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 37s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 47s
✔️ ansible-test-changelog SUCCESS in 4m 27s
✔️ ansible-test-splitter SUCCESS in 4m 50s
✔️ integration-community.aws-1 SUCCESS in 13m 02s
Skipped 21 jobs

[github-actions]

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.