[PR #1663/5759afa1 backport][stable-5] aws_ssm - Refactor boto3 client initialization #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws_ssm - Refactor boto3 client initialization Depends-On: ansible/ansible-zuul-jobs#1748 SUMMARY Move the boto3 client initialization into a consistent point (rather than initializing them on the fly) ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION In preparation for further refactoring and using ansible-collections/amazon.aws#1340 Reviewed-by: Markus Bergholz <git@osuv.de> (cherry picked from commit 5759afa)
tremble
approved these changes
Jan 20, 2023
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
[PR #1664/7b68f119 backport][stable-5] aws_ssm - Refactor _file_transport_command Depends-On: #1668 This is a backport of PR #1664 as merged into main (7b68f11). SUMMARY Yet more cleanup of aws_ssm ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Default filters to empty dictionary SUMMARY Changes the default for the filters option from None to an empty dictionary. Fixes: ansible-collections#1668 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_route_table_info ADDITIONAL INFORMATION This matches what other *info modules (e.g. ec2_vpc_endpoint_info or ec2_vpc_subnet_info) do for the filters option default. Reviewed-by: Alina Buzachis Reviewed-by: Brant Evans <bevans@redhat.com> Reviewed-by: Mark Chappell Reviewed-by: Mike Graves <mgraves@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1663 as merged into main (5759afa).
Depends-On: ansible/ansible-zuul-jobs#1748
SUMMARY
Move the boto3 client initialization into a consistent point (rather than initializing them on the fly)
ISSUE TYPE
COMPONENT NAME
aws_ssm
ADDITIONAL INFORMATION
In preparation for further refactoring and using ansible-collections/amazon.aws#1340